Investigate flaky test-fs-watch-recursive on OS X

[Trott]

https://ci.nodejs.org/job/node-test-commit-osx/5015/nodes=osx1010/console:

not ok 600 parallel/test-fs-watch-recursive
# TIMEOUT

@nodejs/testing

[Trott]

Still seeing this (e.g., https://ci.nodejs.org/job/node-test-commit-osx/5733/nodes=osx1010/console). See it from time to time locally too.

[Trott]

Another one: https://ci.nodejs.org/job/node-test-commit-osx/5813/nodes=osx1010/console

I see it locally from time to time, but not when I'm trying to make it fail (by running it over and over). Would appreciate any insights on making it fail on demand.

[jasnell]

spotting this more often locally also. It's already happened three or four times today.

[Trott]

Now that 60a78ae has landed, I am able to duplicate this failure like this on OS X (after increasing my ulimit -n above the OS X default):

tools/test.py --repeat=256 -j 256  parallel/test-fs-watch-recursive

Fix coming shortly. I'm optimistic that what causes the issue above is what causes it in general.