Skip to content

Glitches in Android build system #2569

@ghost

Description

Hi,

came across some glitches in 'nit/share/libgc/android-setup-libgc.sh' :

  • linux-x86_64 is hardcoded in the line 'path="$ANDROID_NDK/toolchains/$tools_dir/prebuilt/linux-x86_64/bin/"' - does not work on 686
  • gcc release version is hardcoded in the line 'tools_dirs=( arm-linux-androideabi-4.9 x86-4.9 mipsel-linux-android-4.9)'

The tool_dirs should be obtainable by glob expansion.

Also, there was an unfriendly warning when the source was not from git:
'
$ make android
mkdir -p bin
../../bin/nitc -o bin/calculator14.apk src/android14.nit -D debug
fatal: Not a git repository (or any parent up to mount point /home)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
src/calculator.nit:18,2--32: Warning: git_revision used outside of a git repository or git binaries not available (git_revision)
app_version(0, 2, git_revision)
^
'
After adjusting the paths the resulting apk works.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions