Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: File request dialog keeps asking for upload destination if ignored the first time... even after going back to select a destination #48118

Closed
5 of 8 tasks
myomv100 opened this issue Sep 17, 2024 · 6 comments · Fixed by #50524
Closed
5 of 8 tasks

[Bug]: File request dialog keeps asking for upload destination if ignored the first time... even after going back to select a destination #48118

myomv100 opened this issue Sep 17, 2024 · 6 comments · Fixed by #50524
Assignees
@skjnldsv
Labels
3. to review Waiting for reviews 30-feedback bug feature: files feature: sharing

Comments

@myomv100
Copy link

myomv100 commented Sep 17, 2024 •
edited
Loading

⚠️ This issue respects the following points: ⚠️

Bug description

The issue is that the file request dialog doesn't take you to the next step in the wizard if you click continue before entering an upload destination. This is most likely a front-end related issue.

Steps to reproduce

  1. From the file app, click new
  2. Click Create a file request
  3. Enter a subject.
  4. Pretend you forgot to specify an upload destination.
  5. Enter a note
  6. Click Continue
  7. Try now to specify an upload destination.
  8. Click Continue
  9. The dialog does not seem to see the upload destination and keeps asking you to fill the blank.

Expected behavior

Going to the next step that allows you to set a password and expiration date.

Nextcloud Server version

30

Operating system

Other

PHP engine version

PHP 8.2

Web server

Nginx

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost:8007"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "30.0.0.14",
        "overwrite.cli.url": "https:\/\/round-lake.dustinice.workers.dev:443\/https\/localhost:8007",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "updater.release.channel": "git",
        "installed": true
    }
}

List of activated Apps

Enabled:
  - cloud_federation_api: 1.13.0
  - comments: 1.20.1
  - contactsinteraction: 1.11.0
  - dashboard: 7.10.0
  - dav: 1.31.1
  - federatedfilesharing: 1.20.0
  - federation: 1.20.0
  - files: 2.2.0
  - files_reminders: 1.3.0
  - files_sharing: 1.22.0
  - files_trashbin: 1.20.1
  - files_versions: 1.23.0
  - lookup_server_connector: 1.18.0
  - oauth2: 1.18.1
  - provisioning_api: 1.20.0
  - settings: 1.13.0
  - sharebymail: 1.20.0
  - systemtags: 1.20.0
  - theming: 2.5.0
  - twofactor_backupcodes: 1.19.0
  - updatenotification: 1.20.0
  - user_status: 1.10.0
  - weather_status: 1.10.0
  - webhook_listeners: 1.1.0-dev
  - workflowengine: 2.12.0
Disabled:
  - admin_audit: 1.20.0
  - encryption: 2.18.0
  - files_external: 1.22.0
  - testing: 1.20.0
  - user_ldap: 1.21.0

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response
@myomv100 myomv100 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Sep 17, 2024
@joshtrichards joshtrichards changed the title [Bug]: Creating a file request dialog crashes if you submit before entering an upload destination. [Bug]: File request dialog keeps asking for upload destination if left blank the first time (even fater entering it) Sep 21, 2024
@joshtrichards joshtrichards changed the title [Bug]: File request dialog keeps asking for upload destination if left blank the first time (even fater entering it) [Bug]: File request dialog keeps asking for upload destination if left blank the first time (even after entering it) Sep 22, 2024
@joshtrichards joshtrichards added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 29, 2024
@joshtrichards joshtrichards changed the title [Bug]: File request dialog keeps asking for upload destination if left blank the first time (even after entering it) [Bug]: File request dialog keeps asking for upload destination if ignored the first time... even after going back to select a destination Sep 29, 2024
@joshtrichards
Copy link
Member

Reproduced. Thanks for the report, @myomv100!

@skjnldsv skjnldsv self-assigned this Oct 11, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2024

  • Pretend you forgot to specify an upload destination.

Hi,

I don't even understand how you're able to click continue.
If you don't enter an upload destination, the default is the root and will block you from going further as you cannot share the root folder.
Image

@joshtrichards
Copy link
Member

If you skip it the first time, when you go back after the error pops up, even if you select a reasonable path and click Continue it just refuses to go forward. It keeps spitting out the error saying it can't be the root directory (even though I've changed it to a sub-folder.

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2024 •
edited
Loading

If you skip it the first time

That's what I don't understand, you cannot skip it.
It blocks you from going further if it's not correct the first time

@joshtrichards
Copy link
Member

It blocks you, yes. Then you select a (valid) upload destination. Yet the error remains and you still can't continue.

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2024

Aaaaah, okay! Thanks for your patience with me Josh 🤦

@falghamdi125 falghamdi125 mentioned this issue Jan 6, 2025
Closed
4 tasks
This was referenced Jan 29, 2025
Closed
Merged
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews 30-feedback bug feature: files feature: sharing
Projects
None yet
Milestone
No milestone
4 participants
@joshtrichards @skjnldsv @szaimen @myomv100