Skip to content

use MessageBuffer constructor reflection only when required #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xerial merged 1 commit into from
Oct 18, 2018
Merged

use MessageBuffer constructor reflection only when required #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 32 additions & 19 deletions msgpack-core/src/main/java/org/msgpack/core/buffer/MessageBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,26 +144,33 @@ public class MessageBuffer
bufferClsName = isLittleEndian ? DEFAULT_MESSAGE_BUFFER : BIGENDIAN_MESSAGE_BUFFER;
}

try {
// We need to use reflection here to find MessageBuffer implementation classes because
// importing these classes creates TypeProfile and adds some overhead to method calls.
if (DEFAULT_MESSAGE_BUFFER.equals(bufferClsName)) {
// No need to use reflection here, we're not using a MessageBuffer subclass.
mbArrConstructor = null;
mbBBConstructor = null;
}
else {
try {
// We need to use reflection here to find MessageBuffer implementation classes because
// importing these classes creates TypeProfile and adds some overhead to method calls.

// MessageBufferX (default, BE or U) class
Class<?> bufferCls = Class.forName(bufferClsName);
// MessageBufferX (default, BE or U) class
Class<?> bufferCls = Class.forName(bufferClsName);

// MessageBufferX(byte[]) constructor
Constructor<?> mbArrCstr = bufferCls.getDeclaredConstructor(byte[].class, int.class, int.class);
mbArrCstr.setAccessible(true);
mbArrConstructor = mbArrCstr;
// MessageBufferX(byte[]) constructor
Constructor<?> mbArrCstr = bufferCls.getDeclaredConstructor(byte[].class, int.class, int.class);
mbArrCstr.setAccessible(true);
mbArrConstructor = mbArrCstr;

// MessageBufferX(ByteBuffer) constructor
Constructor<?> mbBBCstr = bufferCls.getDeclaredConstructor(ByteBuffer.class);
mbBBCstr.setAccessible(true);
mbBBConstructor = mbBBCstr;
}
catch (Exception e) {
e.printStackTrace(System.err);
throw new RuntimeException(e); // No more fallback exists if MessageBuffer constructors are inaccessible
// MessageBufferX(ByteBuffer) constructor
Constructor<?> mbBBCstr = bufferCls.getDeclaredConstructor(ByteBuffer.class);
mbBBCstr.setAccessible(true);
mbBBConstructor = mbBBCstr;
}
catch (Exception e) {
e.printStackTrace(System.err);
throw new RuntimeException(e); // No more fallback exists if MessageBuffer constructors are inaccessible
}
}
}
}
Expand Down Expand Up @@ -266,7 +273,10 @@ public static MessageBuffer wrap(ByteBuffer bb)
private static MessageBuffer newMessageBuffer(byte[] arr, int off, int len)
{
checkNotNull(arr);
return newInstance(mbArrConstructor, arr, off, len);
if (mbArrConstructor != null) {
return newInstance(mbArrConstructor, arr, off, len);
}
return new MessageBuffer(arr, off, len);
}

/**
Expand All @@ -278,7 +288,10 @@ private static MessageBuffer newMessageBuffer(byte[] arr, int off, int len)
private static MessageBuffer newMessageBuffer(ByteBuffer bb)
{
checkNotNull(bb);
return newInstance(mbBBConstructor, bb);
if (mbBBConstructor != null) {
return newInstance(mbBBConstructor, bb);
}
return new MessageBuffer(bb);
}

/**
Expand Down