Bug 1919718 - Part 3: Update color on AfterSetAttr and add tests r=emilio

I realized that this should not be specific to IDL setter.

Differential Revision: https://phabricator.services.mozilla.com/D278959

Author: saschanaz

dom/html/HTMLInputElement.cpp

@@ -1553,6 +1553,8 @@ void HTMLInputElement::AfterSetAttr(int32_t aNameSpaceID, nsAtom* aName,
       }
       UpdatePlaceholderShownState();
       needValidityUpdate = true;
+    } else if (aName == nsGkAtoms::colorspace || aName == nsGkAtoms::alpha) {
+      UpdateColor();
     }
 
     if (CreatesDateTimeWidget()) {
@@ -1629,11 +1631,6 @@ bool HTMLInputElement::Alpha() const {
   return HasAttr(nsGkAtoms::alpha);
 }
 
-void HTMLInputElement::SetAlpha(bool aValue, ErrorResult& aRv) {
-  SetHTMLBoolAttr(nsGkAtoms::alpha, aValue, aRv);
-  UpdateColor();
-}
-
 void HTMLInputElement::GetAutocomplete(nsAString& aValue) {
   if (!DoesAutocompleteApply()) {
     return;
@@ -1680,12 +1677,6 @@ StyleColorSpace HTMLInputElement::GetColorSpaceEnum() const {
   return StyleColorSpace::Srgb;
 }
 
-void HTMLInputElement::SetColorSpace(const nsAString& aValue,
-                                     ErrorResult& aRv) {
-  SetHTMLAttr(nsGkAtoms::colorspace, aValue, aRv);
-  UpdateColor();
-}
-
 void HTMLInputElement::GetFormEnctype(nsAString& aValue) {
   GetEnumAttr(nsGkAtoms::formenctype, "", kFormDefaultEnctype->tag, aValue);
 }
@@ -2187,6 +2178,10 @@ MOZ_CAN_RUN_SCRIPT_BOUNDARY void HTMLInputElement::UpdateColor() {
   // agent must run update a color well control color given the element.
   // (But it involves setting value, which will run sanitization, which will
   // call the same function. So we just call Get/SetValue here.)
+  if (mType != FormControlType::InputColor) {
+    // This is only needed for color, basically no-op for others.
+    return;
+  }
   if (!mValueChanged) {
     SetDefaultValueAsValue();
     return;

dom/html/HTMLInputElement.h

@@ -453,7 +453,9 @@ class HTMLInputElement final : public TextControlElement,
   }
 
   bool Alpha() const;
-  void SetAlpha(bool aValue, ErrorResult& aRv);
+  void SetAlpha(bool aValue, ErrorResult& aRv) {
+    SetHTMLBoolAttr(nsGkAtoms::alpha, aValue, aRv);
+  }
 
   void GetAlt(nsAString& aValue) { GetHTMLAttr(nsGkAtoms::alt, aValue); }
   void SetAlt(const nsAString& aValue, ErrorResult& aRv) {
@@ -483,7 +485,9 @@ class HTMLInputElement final : public TextControlElement,
 
   void GetColorSpace(nsAString& aValue) const;
   StyleColorSpace GetColorSpaceEnum() const;
-  void SetColorSpace(const nsAString& aValue, ErrorResult& aRv);
+  void SetColorSpace(const nsAString& aValue, ErrorResult& aRv) {
+    SetHTMLAttr(nsGkAtoms::colorspace, aValue, aRv);
+  }
 
   bool IsRadioOrCheckbox() const {
     return mType == FormControlType::InputCheckbox ||

testing/web-platform/tests/html/semantics/forms/the-input-element/color.window.js

@@ -244,3 +244,19 @@ test(() => {
   input.value = "color(display-p3 3 none .2 / .6)";
   assert_equals(input.value, "color(display-p3 3 0 0.2 / 0.6)");
 }, "Display P3 colors can be out-of-bounds");
+
+test(() => {
+  const input = document.createElement("input");
+  input.type = "color";
+  input.value = "white";
+  input.setAttribute("colorspace", "display-p3");
+  assert_equals(input.value, "color(display-p3 1 1 1)");
+}, "Setting colorspace by setAttribute should update the value");
+
+test(() => {
+  const input = document.createElement("input");
+  input.type = "color";
+  input.value = "blue";
+  input.setAttribute("alpha", "");
+  assert_equals(input.value, "color(srgb 0 0 1)");
+}, "Setting alpha by setAttribute should update the value");