Bug 2007539 - [devtools] Reload pages as Firefox does in DevTools tests. r=devtools-reviewers,nchevobbe

The `gBrowser.reloadTab` method was doing a very light reload,
which could preserve iframe overriden locations.
The new method ensures we load the original HTML content back,
this seems to also have an impact on keep-alive which is not longer guaranteed.

Only supports reloading the currently selected tab, to better replicate
real user scenarios. But also to comply to `BrowserCommands.reload`,
which only supports reloading the selected tab.

Also tune the har test, now that requests are really cancelled
and we may try to fetch reponse content for such request.

Differential Revision: https://phabricator.services.mozilla.com/D277433

Author: ochameau

devtools/client/aboutdebugging/test/browser/head.js

@@ -210,7 +210,12 @@ async function closeWebExtAboutDevtoolsToolbox(devtoolsWindow, win) {
 async function reloadAboutDebugging(tab) {
   info("reload about:debugging");
 
-  await reloadBrowser(tab.linkedBrowser);
+  is(
+    gBrowser.selectedTab,
+    tab,
+    "The about:debugging tab is the currently selected tab"
+  );
+  await reloadSelectedTab();
   const browser = tab.linkedBrowser;
   const document = browser.contentDocument;
   const window = browser.contentWindow;

devtools/client/accessibility/test/browser/browser_accessibility_tree_audit_all.js

@@ -12,7 +12,7 @@ addA11YPanelTask(
     const { doc, toolbox } = env;
     info("Reload to have a clean state");
     // This is needed to reproduce the issue from Bug 1929891
-    await reloadBrowser();
+    await reloadSelectedTab();
 
     info(`Select the "All issues" item to run all audits at once`);
     await toggleMenuItem(doc, toolbox.doc, TREE_FILTERS_MENU_ID, 1);

devtools/client/anti-tracking/test/browser/browser_anti_tracking_panel.js

@@ -209,7 +209,7 @@ add_task(async function test_unblock_single_request() {
     "Tracker should now be unblocked in debugger state"
   );
 
-  await reloadBrowser(tab.linkedBrowser);
+  await reloadSelectedTab();
 
   // Test that the tracker would now load
   result = await loadTracker(tab.linkedBrowser);
@@ -416,7 +416,7 @@ add_task(async function test_unblock_selected_button() {
   );
 
   // Test that both trackers now load successfully
-  await reloadBrowser(tab.linkedBrowser);
+  await reloadSelectedTab();
 
   result = await loadTracker(tab.linkedBrowser, "https://tracking.example.org");
   is(result, "loaded", "First tracker should load after bulk unblock");

devtools/client/debugger/test/mochitest/browser_dbg-blackbox.js

@@ -140,7 +140,7 @@ add_task(async function testBlackBoxOnToolboxRestart() {
   await openContextMenuInDebugger(dbg, "gutterElement", 2);
   await selectBlackBoxContextMenuItem(dbg, "blackbox-line");
 
-  await reloadBrowser();
+  await reloadSelectedTab();
   // Wait a little bit incase of a pause
   await wait(1000);
 
@@ -159,7 +159,7 @@ add_task(async function testBlackBoxOnToolboxRestart() {
   // Wait for blackbox action and requests to settle to avoid unhandled promise
   // rejections due to pending promises.
   const onBlackboxDone = waitForDispatch(dbg2.store, "BLACKBOX_SOURCE_RANGES");
-  await reloadBrowser();
+  await reloadSelectedTab();
 
   info("Wait for the blackbox action to complete");
   await onBlackboxDone;

devtools/client/debugger/test/mochitest/browser_dbg-event-breakpoints-fission.js

@@ -22,7 +22,7 @@ add_task(async function () {
   ]);
 
   info("Assert early timeout event breakpoint gets hit");
-  const waitForReload = reloadBrowser();
+  const waitForReload = reloadSelectedTab();
 
   await waitForPaused(dbg);
   await assertPausedAtSourceAndLine(

devtools/client/debugger/test/mochitest/browser_dbg-inline-cache.js

@@ -44,7 +44,7 @@ add_task(async function () {
   const dbg = createDebuggerContext(toolbox);
   await waitForSource(dbg, "inline-cache.html");
   info("Reload tab to ensure debugger finds script");
-  await reloadBrowser();
+  await reloadSelectedTab();
   let pageValue = await getPageValue(tab);
   is(pageValue, "let x = 1;", "Content loads from network, has doc value 1");
   await waitForSource(dbg, "inline-cache.html");
@@ -64,7 +64,7 @@ add_task(async function () {
   makeChanges();
 
   info("Reload inside debugger with toolbox caching disabled (attempt 1)");
-  await reloadBrowser();
+  await reloadSelectedTab();
   pageValue = await getPageValue(tab);
   is(pageValue, "let x = 2;", "Content loads from network, has doc value 2");
   await waitForLoadedSource(dbg, "inline-cache.html");
@@ -79,7 +79,7 @@ add_task(async function () {
   makeChanges();
 
   info("Reload inside debugger with toolbox caching disabled (attempt 2)");
-  await reloadBrowser();
+  await reloadSelectedTab();
   pageValue = await getPageValue(tab);
   is(pageValue, "let x = 3;", "Content loads from network, has doc value 3");
   await waitForLoadedSource(dbg, "inline-cache.html");
@@ -101,7 +101,7 @@ add_task(async function () {
   // document contents.
 
   info("Reload inside debugger with toolbox caching enabled (attempt 1)");
-  await reloadBrowser();
+  await reloadSelectedTab();
   pageValue = await getPageValue(tab);
   is(pageValue, "let x = 4;", "Content loads from network, has doc value 4");
   await waitForLoadedSource(dbg, "inline-cache.html");
@@ -115,7 +115,7 @@ add_task(async function () {
   makeChanges();
 
   info("Reload inside debugger with toolbox caching enabled (attempt 2)");
-  await reloadBrowser();
+  await reloadSelectedTab();
   pageValue = await getPageValue(tab);
   is(pageValue, "let x = 5;", "Content loads from network, has doc value 5");
   await waitForLoadedSource(dbg, "inline-cache.html");

devtools/client/debugger/test/mochitest/browser_dbg-project-search.js

@@ -254,7 +254,7 @@ add_task(async function testSearchExcludePatterns() {
   );
 
   info("Assert that the exclude pattern is persisted across reloads");
-  await reloadBrowser();
+  await reloadSelectedTab();
   await openProjectSearch(dbg);
 
   const excludePatternsInputElement = await waitForElement(

devtools/client/debugger/test/mochitest/browser_dbg-unselected-pause.js

@@ -54,7 +54,7 @@ add_task(async function () {
   info(
     "Reload the test page, which will trigger the debugger statement in the iframe"
   );
-  const pausedReload = reloadBrowser();
+  const pausedReload = reloadSelectedTab();
 
   const dbg = await assertDebuggerIsHighlightedAndPaused(toolbox);
   const source = findSource(dbg, IFRAME_TEST_COM_URI);
@@ -79,7 +79,7 @@ add_task(async function () {
   info(
     "Reload the test page, which will trigger the debugger statement in the iframe"
   );
-  const pausedReload = reloadBrowser();
+  const pausedReload = reloadSelectedTab();
 
   const dbg = await assertDebuggerIsHighlightedAndPaused(toolbox);
   const topLevelThread =

devtools/client/debugger/test/mochitest/integration/browser_dbg-features-wasm.js

@@ -27,7 +27,7 @@ add_task(async function () {
   // Reload once again, while the console is opened.
   // When opening the debugger, it will still miss the source content.
   // To see the sources, we have to reload while the debugger has been opened.
-  await reloadBrowser();
+  await reloadSelectedTab();
 
   await toolbox.selectTool("jsdebugger");
   const dbg = createDebuggerContext(toolbox);

devtools/client/debugger/test/mochitest/shared-head.js

@@ -1027,7 +1027,7 @@ function deleteExpression(dbg, input) {
  * @static
  */
 async function reload(dbg, ...sources) {
-  await reloadBrowser();
+  await reloadSelectedTab();
   return waitForSources(dbg, ...sources);
 }