Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WT_SESSION doesn’t appear in WSL #3948

Closed
DHowett-MSFT opened this issue Dec 13, 2019 · 3 comments · Fixed by #4157
Closed

WT_SESSION doesn’t appear in WSL #3948

DHowett-MSFT opened this issue Dec 13, 2019 · 3 comments · Fixed by #4157
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@DHowett-MSFT
Copy link
Contributor

We did not realize that WT_SESSION wouldn’t appear in WSL because it’s not in WSLENV.

This may also impact VS Code.

/cc @mixmastamyk
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 13, 2019
@DHowett-MSFT
Copy link
Contributor Author

@benhillis is it valid for us as a hosting application to prepend to the user’s WSLENV?

@DHowett-MSFT DHowett-MSFT added Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Product-Terminal The new Windows Terminal. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 13, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal-1912 milestone Dec 13, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Dec 13, 2019
Open
@benhillis
Copy link
Member

Yeah that should be fine.

@DHowett-MSFT DHowett-MSFT mentioned this issue Jan 9, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Jan 9, 2020
@ghost ghost closed this as completed in #4157 Jan 9, 2020
ghost pushed a commit that referenced this issue Jan 9, 2020
@DHowett
Add WT_SESSION to WSLENV so it propagates into WSL (#4157)
988f0a6 
This makes sure that things running inside WSL can see `WT_SESSION`.

Closes #3948.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 9, 2020
@ghost
Copy link

ghost commented Jan 14, 2020

🎉This issue was addressed in #4157, which has now been successfully released as Windows Terminal Preview v0.8.10091.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Add WT_SESSION to WSLENV so it propagates into WSL microsoft/terminal
3 participants
@DHowett-MSFT @benhillis @zadjii-msft