Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the language override for unpackaged distribution (ZIP, Portable) #18419

Closed
denis-komarov opened this issue Jan 9, 2025 · 2 comments · Fixed by #18684
Closed

Support the language override for unpackaged distribution (ZIP, Portable) #18419

denis-komarov opened this issue Jan 9, 2025 · 2 comments · Fixed by #18684
Labels
External-Blocked-WinUI3 We can't progress until WinUI3 exists. In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@denis-komarov
Copy link

Description of the new feature

Language setting for unpackaged distribution (ZIP, Portable) that allow you to set the language explicitly.

Proposed technical implementation details

The specified issues 16018, 18336 related to support for language settings in unpackaged distributions were closed due to limitations of the Windows platform. These limitations seem to have already been addressed in the Windows platform as of Windows App SDK version 1.6.240701003. This is discussed in [MRTCore] Add Microsoft.Windows.Globalization.ApplicationLanguages ​​class #4523 :

To support language change for un-packaged applications Microsoft.Windows.Globalization.ApplicationLanguages.ApplicationLanguages type is introduced in MRTCore. Microsoft.Windows.Globalization.ApplicationLanguages.PrimaryLanguageOverride property is supported both for packaged and un-packaged WindowsAppSDK apps.
@denis-komarov denis-komarov added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jan 9, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 9, 2025
@DHowett
Copy link
Member

DHowett commented Jan 9, 2025 •
edited
Loading

Thanks!

Terminal does not currently use any version of WinAppSDK, and there is a cost (in performance, in disk space, and in memory usage) to switching. I'll mark this task up and stick it on the backlog.

@DHowett DHowett added Product-Terminal The new Windows Terminal. Priority-3 A description (P3) External-Blocked-WinUI3 We can't progress until WinUI3 exists. labels Jan 9, 2025
@DHowett DHowett added this to the Backlog milestone Jan 9, 2025
@DHowett DHowett changed the title Language setting for unpackaged distribution (ZIP, Portable) Support the language override for unpackaged distribution (ZIP, Portable) Jan 9, 2025
@carlos-zamora carlos-zamora removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 15, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jan 15, 2025
@mdnchauhan
Copy link

Hi,

Thread #1687 is closed. But I am facing same issue in setting the default language in unpackaged application.
As my app tries to set the default lang by - winrt::Windows::Globalization::ApplicationLanguages::PrimaryLanguageOverride
this property throws exception message "The process has no package identity".

Application type- WinUI3 XAML based C++WinRT, Unpackaged App
Microsoft.WindowsAppSDK version 1.6.250205002

Is there any way to fix it or any other property that I can use in unpackaged application for setting the default Lang?

Thanks.

@mdnchauhan mdnchauhan mentioned this issue Mar 10, 2025
Open
DHowett added a commit that referenced this issue Mar 12, 2025
@DHowett
Add support for language override to unpackaged/portable builds
5fae85d 
It turns out that we *can* support language overrides--fairly easily, in
fact!--by simply changing the default Language qualifier.

I elected not to change how packaged language override works until we
are certain this works properly everywhere. Consider it a healthy
distrust of the Windows App Platform.

Closes #18419
Closes #18336
Closes #17619
@DHowett DHowett mentioned this issue Mar 12, 2025
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
External-Blocked-WinUI3 We can't progress until WinUI3 exists. In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add support for language override to unpackaged/portable builds microsoft/terminal
4 participants
@DHowett @carlos-zamora @denis-komarov @mdnchauhan