Clicking a command in Terminal Chat that contains sudo produces a sudo error

[sirredbeard]

Windows Terminal version

1.20.3491.0

Windows build number

10.0.22631.0

Other Software

Fedora Remix for WSL 39

Steps to reproduce

Ask Terminal chat for a command that will produce a multiline sudo command, for example: How do I install Kubernetes on Linux?

Expected Behavior

When clicking sudo commands in Terminal Chat to run them in a WSL instance, Terminal allows the user to enter the sudo password either before continuing passing more commands and/or without causing a sudo error.

Actual Behavior

When clicking multiline sudo commands in Terminal Chat to run them in a WSL instance, Terminal passes something to the initial sudo that causes a password error.

Recording.2023-12-19.154923.mp4

[zadjii-msft]

Welp, yea that makes sense. Not sure if there's a good heuristic here for us to use to solve this cleanly - if it's just on enter, then what if the user mistyped the first password? This will require some discussion to figure out the right solution.

[sirredbeard]

This is not going to be an easy one to solve and there are a lot of potential edge cases to account for.

Two potential ideas:

1. You could dynamically parse a batch of sudo commands into a single sudo bash -c 'sudo echo hello; sudo echo world'. However, I think there is a very strong argument for not messing with any of the commands from Terminal Chat. In this example, not all users use bash and not all distros include bash. On the other hand, if you did introduce dynamic parsing of commands from Terminal Chat, I think the parsing rules should be defined in a separate .json that could be easily modified if edge cases appear.

2. You could insert a pause after pasting the first sudo command and check for a zero exit status from that command before pasting the next sudo command, if that is possible. That itself wouldn't account for a non-sudo-related non-zero error like running apt install on RHEL and further sudo commands would likely fail too if the first one did or worse, leave the Linux environment in a messy state, so perhaps it could just halt all further pasting at that point.

[DHowett]

Intelligent Terminal's where it's at! :D