Skip to content

Description of "documentChanges" of "WorkspaceEdit" is unclear #240

Description

The documentChanges field of a WorkspaceEdit is described as follows:

An array of TextDocumentEdits to express changes to specific a specific version of a text document. Whether a client supports versioned document edits is expressed via WorkspaceClientCapabilites.versionedWorkspaceEdit.

While the wording to specific a specific is clearly wrong, it is unclear what is meant. Do all these individual TextDocumentEdits have to be applied to the same specific version of a text document?

  • If yes, what would be the point of having a VersionedTextDocumentIdentifier in each TextDocumentEdit – and possibly different ones??
  • If no, the first sentence of the description should be reworded, see my suggestion below.

An array of TextDocumentEdits each expressing a change to a specific version of a text document.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions