Maven clean install failing on main

[clamey]

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

This is on origin/main

Describe the bug

Maven fails to install in the test phase of bot-connector.

To Reproduce

Steps to reproduce the behavior:

1. git clone https://github.com/Microsoft/botbuilder-java.git
2. cd cd botbuilder-java
3. mvn clean install

INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ bot-connector ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 42 source files to /Users/topher/src/botbuilder-java/libraries/bot-connector/target/test-classes
[INFO] -------------------------------------------------------------
[WARNING] COMPILATION WARNING :
[ NOTE: 55 warnings truncated for readability ]
[INFO] -------------------------------------------------------------
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/topher/src/botbuilder-java/libraries/bot-connector/src/test/java/com/microsoft/bot/connector/JwtTokenExtractorTests.java:[190,55] cannot find symbol
  symbol:   variable sha256WithRSAEncryption_oid
  location: class sun.security.x509.AlgorithmId
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Microsoft BotBuilder Java SDK Parent 4.6.0-preview8:
[INFO]
[INFO] Microsoft BotBuilder Java SDK Parent ............... SUCCESS [  1.807 s]
[INFO] com.microsoft.bot:bot-schema ....................... SUCCESS [  7.122 s]
[INFO] com.microsoft.bot:bot-connector .................... FAILURE [  3.129 s]
[INFO] com.microsoft.bot:bot-builder ...................... SKIPPED
[INFO] com.microsoft.bot:bot-integration-core ............. SKIPPED
[INFO] com.microsoft.bot:bot-dialogs ...................... SKIPPED
[INFO] com.microsoft.bot:bot-applicationinsights .......... SKIPPED
[INFO] com.microsoft.bot:bot-ai-luis-v3 ................... SKIPPED
[INFO] com.microsoft.bot:bot-ai-qna ....................... SKIPPED
[INFO] com.microsoft.bot:bot-azure ........................ SKIPPED
[INFO] com.microsoft.bot:bot-integration-spring ........... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  12.158 s
[INFO] Finished at: 2021-02-15T15:14:27-07:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:testCompile (default-testCompile) on project bot-connector: Compilation failure
[ERROR] /Users/topher/src/botbuilder-java/libraries/bot-connector/src/test/java/com/microsoft/bot/connector/JwtTokenExtractorTests.java:[190,55] cannot find symbol
[ERROR]   symbol:   variable sha256WithRSAEncryption_oid
[ERROR]   location: class sun.security.x509.AlgorithmId
[ERROR]
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :bot-connector

Expected behavior

I would expect the maven build to complete successfully.

Additional context

Really I'm just trying to get sample #46 to build.

Maven and Java info:

~/src/botbuilder-java [main|✔ ]
topher@host  ➤  mvn -v
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec
Java version: 15.0.1, vendor: N/A, runtime: /usr/local/Cellar/openjdk/15.0.1/libexec/openjdk.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"
~/src/botbuilder-java [main|✔ ]
topher@host  ➤  java -version
openjdk version "1.8.0_282"
OpenJDK Runtime Environment (Zulu 8.52.0.23-macosx)-Microsoft-Azure-restricted (build 1.8.0_282-b08)
OpenJDK 64-Bit Server VM (Zulu 8.52.0.23-macosx)-Microsoft-Azure-restricted (build 25.282-b08, mixed mode)

[tracyboehrer]

@clamey Ultimately what we have to do is eliminate the use of that Sun specific package in the Connector tests. Researching that now.

[tracyboehrer]

@clamey Do:

mvn install -Dmaven.test.skip=true" to get past this for the time being. Those tests run every time we build and commit, so for your purposes this should be fine.