Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Resolve import of autorest code #541

@tracyboehrer

Description

@tracyboehrer

To get around Java 1.7 dependency, RxJava use, and some Jackson serializer issues the autorest code from https://github.com/Azure/autorest-clientruntime-for-java/tree/master/client-runtime/src/main/java/com/microsoft/rest was copied into bot-connector.

Unknown if the com.microsoft.bot.azure package is needed or if there is an alternative to now "owning" this code. At the very least the AzureJacksonAdaptor (and it's dependencies), and AzureResponseBuilder are being used.

Options

  1. Bite the bullet and live with Java 1.7 and RxJava and used release autorest client. Not preferred.
  2. Retain imported code as is (with mods). This allows us to more easily update when the official version improves.
  3. Retain imported code, but reduce to only the needed classes.
  4. Write our own. See https://stackoverflow.com/questions/221442/how-do-you-create-a-rest-client-for-java. The OkHttp + RetroFit is likely still a valid option. But then... we are basically talking about option 3.

List of potential clients
https://stackoverflow.com/questions/221442/how-do-you-create-a-rest-client-for-java

Metadata

Metadata

Assignees

Labels

Area: SDKGeneral SDK issues that don't clearly map to other areas (e.g.: helper methods)P0Must Fix. Release-blockerSize: LThe issue is complex but it is well understood, it will take 4 to 8 days to completetechnical-debtRefactoring, follow best practices, improve test coverage, etc.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions