From 8cf4699391ba549b28e7f875d53e26e4f664c89f Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Mon, 14 Aug 2017 10:21:32 -0700 Subject: [PATCH 1/2] session.ts: Revert some `emptyArray` back to `undefined` --- src/server/session.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/server/session.ts b/src/server/session.ts index 80909362989a9..e33b3e4d1f5a8 100644 --- a/src/server/session.ts +++ b/src/server/session.ts @@ -585,7 +585,7 @@ namespace ts.server { ): ReadonlyArray | ReadonlyArray { const { project, file } = this.getFileAndProject(args); if (isSemantic && isDeclarationFileInJSOnlyNonConfiguredProject(project, file)) { - return emptyArray; + return undefined; } const scriptInfo = project.getScriptInfoForNormalizedPath(file); const diagnostics = selector(project, file); @@ -601,7 +601,7 @@ namespace ts.server { const definitions = project.getLanguageService().getDefinitionAtPosition(file, position); if (!definitions) { - return emptyArray; + return undefined; } if (simplifiedResult) { @@ -669,7 +669,7 @@ namespace ts.server { const occurrences = project.getLanguageService().getOccurrencesAtPosition(file, position); if (!occurrences) { - return emptyArray; + return undefined; } return occurrences.map(occurrence => { @@ -913,7 +913,7 @@ namespace ts.server { if (simplifiedResult) { const nameInfo = defaultProject.getLanguageService().getQuickInfoAtPosition(file, position); if (!nameInfo) { - return emptyArray; + return undefined; } const displayString = displayPartsToString(nameInfo.displayParts); @@ -1176,7 +1176,7 @@ namespace ts.server { const completions = project.getLanguageService().getCompletionsAtPosition(file, position); if (!completions) { - return emptyArray; + return undefined; } if (simplifiedResult) { return mapDefined(completions.entries, entry => { From 630d90504d003f093d38b08b09a493bef2bc9152 Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Mon, 14 Aug 2017 13:05:19 -0700 Subject: [PATCH 2/2] Fix --- src/server/session.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/session.ts b/src/server/session.ts index e33b3e4d1f5a8..92d402b343a53 100644 --- a/src/server/session.ts +++ b/src/server/session.ts @@ -585,7 +585,7 @@ namespace ts.server { ): ReadonlyArray | ReadonlyArray { const { project, file } = this.getFileAndProject(args); if (isSemantic && isDeclarationFileInJSOnlyNonConfiguredProject(project, file)) { - return undefined; + return emptyArray; } const scriptInfo = project.getScriptInfoForNormalizedPath(file); const diagnostics = selector(project, file);