Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List all missing controls on XML deserialisation #19

Closed
methusalah opened this issue Aug 21, 2014 · 7 comments
Closed

List all missing controls on XML deserialisation #19

methusalah opened this issue Aug 21, 2014 · 7 comments

Comments

@methusalah
Copy link
Owner

Each time we type a wrong value in the XML and the engine bug instead of say what's wrong, we have to report it to create a control if possible.

@methusalah
Copy link
Owner Author

Colors of the particles need default val

@meltzow
Copy link
Collaborator

meltzow commented May 9, 2015

Hi,
it's possible to translate? :bowtie:

@methusalah
Copy link
Owner Author

done !

@meltzow
Copy link
Collaborator

meltzow commented May 16, 2015

hi, can you explain it in more detail? I dont understand what is to do here. What do you mean with control?

@methusalah
Copy link
Owner Author

When a user write an XML definition, he may make a lot of "mistakes", for exemple :

  • Text case problem
  • a value out of range
  • a value unknown by the enigne
  • etc.
    From typing errors or else. The code that read the definitions and create the bluprints (Builders) has too few checks and may let errors pass throught.

For exemple, if you type an unknown element name, the code won't use its value and the defaut value will be used instead, leading to hard-to-source bugs.

We should found a way to solve that problem. The code must detect errors and throw warnings, or maybe there is another solution?

@meltzow meltzow self-assigned this May 21, 2015
@meltzow
Copy link
Collaborator

meltzow commented Jun 17, 2015

I prepare a EntityEditor (see here https://github.com/wuendsch/OpenRTS-EntityEditor).
One of the last steps are now, to integrate it into our current system

@meltzow
Copy link
Collaborator

meltzow commented Jun 20, 2015

The EntityEnditor is now released for a first beta version. It's possible that we integrate it directly into OpenRTS repository. I close this issue now.

@meltzow meltzow closed this as completed Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants