Should declare_dependency have an compile_static_args argument?

[moi15moi]

In my header, I have this little snippet to properly export symbols.

#if defined(_WIN32) && !defined(FFMS_STATIC)
#	if defined(FFMS_EXPORTS)
#		define FFMS_API(ret) FFMS_EXTERN_C __declspec(dllexport) ret FFMS_CC
#	else
#		define FFMS_API(ret) FFMS_EXTERN_C __declspec(dllimport) ret FFMS_CC
#	endif
#elif defined(__GNUC__) && __GNUC__ >= 4
#	define FFMS_API(ret) FFMS_EXTERN_C __attribute__((visibility("default"))) ret FFMS_CC
#else
#	define FFMS_API(ret) FFMS_EXTERN_C ret FFMS_CC
#endif

To avoid using __declspec(dllexport) when compiling a static lib, I define -DFFMS_STATIC in cpp_static_args like this:

ffms2_lib = library(
    XXX,
    cpp_args: ['-DFFMS_EXPORTS'],
    cpp_static_args: ['-DFFMS_STATIC'],
)

But, the problem is how can I tell the consumer of ffms2_dep to also use the flag -DFFMS_STATIC when it's a static library? Shouldn't
declare_dependency have a compile_static_args argument? Currently, there is only compile_args available, but since the user can use default_library=both, there isn't any way for me to specify for static lib?

ffms2_dep = declare_dependency(
    link_with: ffms2_lib,
    include_directories: includes,
    # How to specify '-DFFMS_STATIC', but only for static lib?
)

meson.override_dependency('ffms2', ffms2_dep)

I have the same problem with pkg_config.generate, but Cflags.private allow to fix that and there is already an issue about it

pkg_config = import('pkgconfig')
pkg_config.generate(
    ffms2_lib,
    # How to specify '-DFFMS_STATIC', but only for static lib?
)

[dcbaker]

Yes, you should be able to add static arguments to declare_dependencies, as well as shared arguments, and per-language arguments like you can to build targets: #5723

I am actively working on the problem, but there's a lot of core refactoring that needs to be finished before we'll be able to get there.

[moi15moi]

Ok, thank you!