Skip to content

Compile scss and coffee for 2.0#307

Closed
paulsponagl wants to merge 2 commits intolocomotivecms:2.0.0.rcfrom
paulsponagl:compile_scss_and_coffee_for_2.0
Closed

Compile scss and coffee for 2.0#307
paulsponagl wants to merge 2 commits intolocomotivecms:2.0.0.rcfrom
paulsponagl:compile_scss_and_coffee_for_2.0

Conversation

@paulsponagl
Copy link
Copy Markdown
Contributor

with this pull one is able to use Sass(scss) Syntax for css and Coffeescript Syntax for js within the backend.

as you see within the code i added this feature within carrierwave (version :compile)

two locomotive configuration options are provided: sass_process_options and coffeescript_process_options

rspec test is included.

@imports within scss will work only when using file storage (for now).

@paulsponagl
Copy link
Copy Markdown
Contributor Author

i forgot to mention that the cucumber tests had errors - to me that seemed unrelated to the changes within this pull request so i simply ignored them :)

Update: did, now that you fixed the features i was able to track down a bug too / cucumber tests are running with this pull too now...

@svyatogor
Copy link
Copy Markdown

It would also be nice to enable compass usage in the scss. compass is there anyway, as it is required by locomotive itself.

@paulsponagl
Copy link
Copy Markdown
Contributor Author

use:

config.sass_process_options = { :load_paths => [File.join(Compass.base_directory, 'frameworks','compass','stylesheets')]};

within Locomotive.configure

and e.g.

@import "compass/css3/box-shadow";

/* globals */
$global_bg_color: #ffffff;
$default_content_width: 960px;

will work

Best
Paul

PS: Did is willing to merge this with a few modifications - you may wait for this if you want to ...

@mariovisic
Copy link
Copy Markdown
Member

Sorry Paul about the delay in getting back to you.

We'll look at including this for the 2.1 release, we aren't adding any new features for 2.0 at the moment, just concentrating on bugfixes.

@paulsponagl
Copy link
Copy Markdown
Contributor Author

closing this - changed the way assets are compiled.
will open a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants