fallocate system call fails on NTFS and eCryptFS

[robertpfeiffer]

This bug appeared in butler in version 15.18 and wasn't there before. It's caused by the fallocate syscall failing in preallocate_other.go
more here: https://itch.io/t/867378/problem-installing-some-games-on-linux

[fasterthanlime]

Yeah, I've seen other reports of this, going to work on a fallback now that I'm back from "vacation".

Thanks for bumping this!

[fasterthanlime]

Okay, I think my fix is working.

Before fix

With fallocate support

$ rm -rf test && strace -e trace=fallocate -- butler-before-fix extract source-serif-pro.zip --quiet -d test
fallocate(7, 0, 0, 212300)              = 0
fallocate(7, 0, 0, 72544)               = 0
fallocate(7, 0, 0, 217212)              = 0
fallocate(7, 0, 0, 74164)               = 0
fallocate(7, 0, 0, 217280)              = 0
fallocate(7, 0, 0, 73408)               = 0
fallocate(7, 0, 0, 227008)              = 0
fallocate(7, 0, 0, 75188)               = 0
fallocate(7, 0, 0, 228024)              = 0
fallocate(7, 0, 0, 75016)               = 0
fallocate(7, 0, 0, 222452)              = 0
fallocate(7, 0, 0, 73068)               = 0
fallocate(7, 0, 0, 4519)                = 0
--- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=283031, si_uid=1000} ---
+++ exited with 0 +++

Without fallocate support

$ rm -rf test && strace -e fault=fallocate:error=95 -- butler-before-fix extract source-serif-pro.zip --quiet -d test 2> /dev/null
extracting archive: operation not supported

After fix

With fallocate support

$ rm -rf test && strace -e trace=fallocate -- butler extract source-serif-pro.zip --quiet -d test
fallocate(7, 0, 0, 212300)              = 0
fallocate(7, 0, 0, 72544)               = 0
fallocate(7, 0, 0, 217212)              = 0
fallocate(7, 0, 0, 74164)               = 0
fallocate(7, 0, 0, 217280)              = 0
fallocate(7, 0, 0, 73408)               = 0
fallocate(7, 0, 0, 227008)              = 0
fallocate(7, 0, 0, 75188)               = 0
fallocate(7, 0, 0, 228024)              = 0
fallocate(7, 0, 0, 75016)               = 0
fallocate(7, 0, 0, 222452)              = 0
fallocate(7, 0, 0, 73068)               = 0
fallocate(7, 0, 0, 4519)                = 0
--- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=283569, si_uid=1000} ---
--- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=283569, si_uid=1000} ---
--- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=283569, si_uid=1000} ---
+++ exited with 0 +++

Without fallocate support

$ rm -rf test && strace -e fault=fallocate:error=95 -- butler extract source-serif-pro.zip --quiet -d test 2> /dev/null
$ echo $?
0

[fasterthanlime]

butler v15.19.0 is out with this fix.

As usual, the itch app will automatically update to it over time, but you can force the update by going to Preferences (bottom-left button in sidebar), scrolling down to "Advanced", and clicking "Check for updates"

After that, it should look like this: