Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bclinkinbeard/minimalcomps
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: hxiangong/minimalcomps
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 6 files changed
  • 5 contributors

Commits on May 24, 2011

  1. Configuration menu
    Copy the full SHA
    024f790 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2011

  1. disabled any item that appears in the list but should not be enabled.…

    … This can occur when the list is longer than the list area allows, so the scrollbar appears. If the list height doesn't divide evenly by the list item height, a little sliver of one last item will be visible at the bottom of the list and it can be clicked. This causes an error. I found that disabling the last item solves the problem. I'm not sure if there are other ramifications to this change, such as any need to re-enable list items if the list length changes, etc.
    ElliotMebane committed Jun 7, 2011
    Configuration menu
    Copy the full SHA
    9735dab View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2011

  1. This is an update to a prior commit I made two days ago. It turns out…

    … that in addition to disabling the last item in a list after scrolling to the bottom, the other items need to be manually re-enabled. without re-enabling, the bottom list item position will remain disabled. The new line is around 138, the addition of item.enabled = true in the if condition.
    ElliotMebane committed Jun 10, 2011
    Configuration menu
    Copy the full SHA
    10b25a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2011

  1. Making list addItemAt(), removeItem(), removeItemAt() and removeAll()…

    … work correctly
    kommander committed Aug 23, 2011
    Configuration menu
    Copy the full SHA
    a66730c View commit details
    Browse the repository at this point in the history
  2. initial commit

    kommander committed Aug 23, 2011
    Configuration menu
    Copy the full SHA
    d40d385 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2011

  1. Dummy commit to test stuff.

    tynril committed Nov 8, 2011
    Configuration menu
    Copy the full SHA
    ecca339 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2012

  1. Revert "This is an update to a prior commit I made two days ago. It t…

    …urns out that in addition to disabling the last item in a list after scrolling to the bottom, the other items need to be manually re-enabled. without re-enabling, the bottom list item position will remain disabled. The new line is around 138, the addition of item.enabled = true in the if condition. "
    
    This reverts commit 10b25a4.
    ElliotMebane committed Sep 8, 2012
    Configuration menu
    Copy the full SHA
    b0c14f9 View commit details
    Browse the repository at this point in the history
  2. Revert "disabled any item that appears in the list but should not be …

    …enabled. This can occur when the list is longer than the list area allows, so the scrollbar appears. If the list height doesn't divide evenly by the list item height, a little sliver of one last item will be visible at the bottom of the list and it can be clicked. This causes an error. I found that disabling the last item solves the problem. I'm not sure if there are other ramifications to this change, such as any need to re-enable list items if the list length changes, etc. "
    
    This reverts commit 9735dab.
    ElliotMebane committed Sep 8, 2012
    Configuration menu
    Copy the full SHA
    3bb3197 View commit details
    Browse the repository at this point in the history
  3. Revert "Revert "disabled any item that appears in the list but should…

    … not be enabled. This can occur when the list is longer than the list area allows, so the scrollbar appears. If the list height doesn't divide evenly by the list item height, a little sliver of one last item will be visible at the bottom of the list and it can be clicked. This causes an error. I found that disabling the last item solves the problem. I'm not sure if there are other ramifications to this change, such as any need to re-enable list items if the list length changes, etc. ""
    
    This reverts commit 3bb3197.
    ElliotMebane committed Sep 8, 2012
    Configuration menu
    Copy the full SHA
    0a77390 View commit details
    Browse the repository at this point in the history
  4. Revert "Revert "This is an update to a prior commit I made two days a…

    …go. It turns out that in addition to disabling the last item in a list after scrolling to the bottom, the other items need to be manually re-enabled. without re-enabling, the bottom list item position will remain disabled. The new line is around 138, the addition of item.enabled = true in the if condition. ""
    
    This reverts commit b0c14f9.
    ElliotMebane committed Sep 8, 2012
    Configuration menu
    Copy the full SHA
    5aaa44c View commit details
    Browse the repository at this point in the history
  5. Revert "This is an update to a prior commit I made two days ago. It t…

    …urns out that in addition to disabling the last item in a list after scrolling to the bottom, the other items need to be manually re-enabled. without re-enabling, the bottom list item position will remain disabled. The new line is around 138, the addition of item.enabled = true in the if condition. "
    
    This reverts commit 10b25a4.
    ElliotMebane committed Sep 8, 2012
    Configuration menu
    Copy the full SHA
    52617d9 View commit details
    Browse the repository at this point in the history
  6. Revert "disabled any item that appears in the list but should not be …

    …enabled. This can occur when the list is longer than the list area allows, so the scrollbar appears. If the list height doesn't divide evenly by the list item height, a little sliver of one last item will be visible at the bottom of the list and it can be clicked. This causes an error. I found that disabling the last item solves the problem. I'm not sure if there are other ramifications to this change, such as any need to re-enable list items if the list length changes, etc. "
    
    This reverts commit 9735dab.
    ElliotMebane committed Sep 8, 2012
    Configuration menu
    Copy the full SHA
    36b93eb View commit details
    Browse the repository at this point in the history
  7. Compatibility with ASC 2.0 Font SWF embedding

    ElliotMebane committed Sep 8, 2012
    Configuration menu
    Copy the full SHA
    d0d8619 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2012

  1. Merge pull request #29 from ElliotMebane/master

    Embedded font SWF for ASC 2.0 compatibility.
    bit101 committed Oct 8, 2012
    Configuration menu
    Copy the full SHA
    a73c5a6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #20 from kommander/master

    Fixing List Component and added Readme
    bit101 committed Oct 8, 2012
    Configuration menu
    Copy the full SHA
    4538a7c View commit details
    Browse the repository at this point in the history
  3. Merge pull request #15 from tynril/master

    Prevented crash when numVisibleItems is called with zero
    bit101 committed Oct 8, 2012
    Configuration menu
    Copy the full SHA
    e308f76 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ab5cf3e View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2012

  1. Merge pull request #31 from makc/patch-1

    Fix for the bug introduced in #15
    bit101 committed Oct 9, 2012
    Configuration menu
    Copy the full SHA
    f655a7a View commit details
    Browse the repository at this point in the history
Loading