Skip to content
This repository was archived by the owner on Dec 6, 2018. It is now read-only.
This repository was archived by the owner on Dec 6, 2018. It is now read-only.

Cannot build project on Windows #261

Open

Description

@jsantell

There are bash commands in npm scripts that do not work on Windows.

Activity

  1. jsantell commented on Oct 10, 2017

    @jsantell
    ContributorAuthor

    Related #232, #248, #234

    Also we should no longer require java (closure compiler) to build this project.

  2. jbrthroque commented on Oct 11, 2017

    @jbrthroque

    how to fix this problem?

  3. jsantell commented on Oct 11, 2017

    @jsantell
    ContributorAuthor

    Not use npm scripts (that execute in shell) in package.json but instead call node scripts.

  4. jose-torres-marin commented on Oct 12, 2017

    @jose-torres-marin

    EDIT: Please see the comment below for already-built files instead of building your own.

    @jbrthroque you can modify the package.json locally if you're in a hurry.

    • Remove all references to the _mkdir script
    • Manually create a folder named "build" at root level (alongside index.html, src, etc.)
    • Replace semicolons with ampersands in all scripts (e.g., the "build" script should look like: "build": "npm run build-min & npm run build-dev & npm run build-api")
    • You should be able to do npm run build without errors now.
  5. jsantell commented on Oct 12, 2017

    @jsantell
    ContributorAuthor

    The links in this PR provide links to the built files in the mean time: #262

  6. ksaylor11 commented on Oct 18, 2017

    @ksaylor11

    I followed the instructions given by @jose-torres-marin and I end up with an error:

    missing script: browserify

  7. jsantell commented on Oct 18, 2017

    @jsantell
    ContributorAuthor

    try npm install -g browserify

  8. ksaylor11 commented on Oct 24, 2017

    @ksaylor11

    Still has issues. I've attached the output of running npm run build

    result.txt

  9. jsantell commented on Oct 24, 2017

    @jsantell
    ContributorAuthor

    Looks like you need browserify installed as a global: npm install -g browserify

  10. ksaylor11 commented on Oct 24, 2017

    @ksaylor11

    The results I just posted were after installing browserify globally

  11. jose-torres-marin commented on Nov 1, 2017

    @jose-torres-marin

    @ksaylor11 Since the readme was updated with direct links to built files, hopefully this is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions