Skip to content

Conversation

@cojenco
Copy link
Contributor

@cojenco cojenco commented Nov 30, 2022

This adds a boolean flag use_auth_w_custom_endpoint - whether authentication is required with custom endpoints

  • only used when a custom endpoint in set in conjunction
  • defaults to True and uses authentication
  • if set to False, bypasses authentication

For backwards compatibility

  • by default, auth is bypassed when STORAGE_EMULATOR_HOST is set
  • add bool _is_emulator_set to improve readability

Refactored to ensure preprod testing is not adversely impacted

  • updated docstring to note internal testing used environment variables

Fixes #895 and internal b/258502260

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Nov 30, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2022
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 1, 2022
@cojenco cojenco marked this pull request as ready for review December 1, 2022 00:59
@cojenco cojenco requested review from a team as code owners December 1, 2022 00:59
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2022
@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2022
@andrewsg andrewsg added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@andrewsg andrewsg merged commit 5291c08 into googleapis:main Dec 7, 2022
@cojenco cojenco deleted the useauth branch November 16, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable authentication when a non-default api_endpoint is set (just like the googleapis/nodejs-storage)

3 participants