Skip to content

test: skip test__signing tests for mtls #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arithmetic1728 merged 1 commit into from
Jul 20, 2021
Merged

test: skip test__signing tests for mtls #511

arithmetic1728 merged 1 commit into from
Jul 20, 2021

Conversation

@arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Jul 19, 2021

Add no_mtls decorator to skip all the tests in test__signing.py, if it is running in mtls testing environment.
The reason is mtls uses user credentials instead of service account credentials.

@arithmetic1728 arithmetic1728 requested a review from a team July 19, 2021 22:40
@arithmetic1728 arithmetic1728 requested a review from a team as a code owner July 19, 2021 22:40
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2021
@busunkim96 busunkim96 changed the title fix: skip test__signing tests for mtls test: skip test__signing tests for mtls Jul 20, 2021
@busunkim96
Copy link
Contributor

busunkim96 commented Jul 20, 2021

I edited the title to remove fix so this doesn't end up in the Changelog. Otherwise LGTM!

@arithmetic1728
Copy link
Contributor Author

arithmetic1728 commented Jul 20, 2021

I edited the title to remove fix so this doesn't end up in the Changelog. Otherwise LGTM!

Thanks!

@arithmetic1728 arithmetic1728 merged commit ddd013c into master Jul 20, 2021
@arithmetic1728 arithmetic1728 deleted the fix_mtls branch July 20, 2021 18:00
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@arithmetic1728 @cojenco
fix: skip test__signing tests for mtls (googleapis#511)
e3889d5
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@arithmetic1728 @cojenco
fix: skip test__signing tests for mtls (googleapis#511)
cdfcbea
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arithmetic1728 @busunkim96