Skip to content

Handle data dict type in retry.is_etag_in_json(data) #481

@cojenco

Description

@cojenco

retry.is_etag_in_json(data) is a helper method for conditional retries. It returns a boolean whether or not an etag is contained in the JSON body.

There seem to be use cases in which a dictionary type of data is passed into retry.is_etag_in_json(data). Currently the method is unable to handle dict type data correctly: a JSONDecodeError is caught before examining if an etag is contained within.

Metadata

Metadata

Assignees

Labels

api: storageIssues related to the googleapis/python-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions