docs(samples): add sample to filter certificates#160
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
leahecole
left a comment
There was a problem hiding this comment.
One small change in the test - just want to make sure no leftover resources are around. I request that @m-strzelczyk, @msampathkumar or another teammate also take a look at this to make sure y'all are happy with it product-wise, because I do not know the product at all 😁
|
Hi @FrodoTheTrue, Please could you take a look? |
|
@parthea @leahecole I believe we don't have to request review from Maciej and Sampath, cause this samples is just python equivalent of have already written java samples: https://github.com/googleapis/java-security-private-ca/tree/main/samples/snippets/cloud-client/src/main/java/privateca |
Suggested changes have been implemented. Dismissing the review as reviewer is OOO.
This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.
|
Samples test is failing with This will be resolved when we migrate samples testing to github actions and split up the individual checks into stages. |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
🤖 I have created a release *beep* *boop* --- ### [1.2.2](v1.2.1...v1.2.2) (2022-02-03) ### Features * add api key support ([#172](#172)) ([672e9b0](672e9b0)) * **samples:** add subordinate CA samples ([94b6801](94b6801)) ### Bug Fixes * resolve DuplicateCredentialArgs error when using credentials_file ([d63e401](d63e401)) ### Miscellaneous Chores * release as 1.2.2 ([#170](#170)) ([ee8694c](ee8694c)) ### Documentation * add format requirements on `custom_sans` ([259f1c9](259f1c9)) * mark CaPool.lifetime as IMMUTABLE ([#177](#177)) ([259f1c9](259f1c9)) * **samples:** add sample to filter certificates ([#160](#160)) ([a0ae8b2](a0ae8b2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### [1.2.2](googleapis/python-security-private-ca@v1.2.1...v1.2.2) (2022-02-03) ### Features * add api key support ([#172](googleapis/python-security-private-ca#172)) ([672e9b0](googleapis/python-security-private-ca@672e9b0)) * **samples:** add subordinate CA samples ([94b6801](googleapis/python-security-private-ca@94b6801)) ### Bug Fixes * resolve DuplicateCredentialArgs error when using credentials_file ([d63e401](googleapis/python-security-private-ca@d63e401)) ### Miscellaneous Chores * release as 1.2.2 ([#170](googleapis/python-security-private-ca#170)) ([ee8694c](googleapis/python-security-private-ca@ee8694c)) ### Documentation * add format requirements on `custom_sans` ([259f1c9](googleapis/python-security-private-ca@259f1c9)) * mark CaPool.lifetime as IMMUTABLE ([#177](googleapis/python-security-private-ca#177)) ([259f1c9](googleapis/python-security-private-ca@259f1c9)) * **samples:** add sample to filter certificates ([#160](googleapis/python-security-private-ca#160)) ([a0ae8b2](googleapis/python-security-private-ca@a0ae8b2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
docs(samples): add sample to undelete certificate authority