fix: client_info default values #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losalex
reviewed
Dec 2, 2022
|
|
||
|
|
||
| def test_logging_default_client_info_headers(): | ||
| import re |
Contributor
There was a problem hiding this comment.
Seems like repeated code - can you create one function controlled/operated by parameters?
Contributor
Author
There was a problem hiding this comment.
Yeah unfortunately a lot of these test files contain mostly repeated test code pointed at different services. I considered making a different file for just these tests that could share more logic, but then decided to follow the existing conventions instead. Let me know if you think that makes sense
Contributor
There was a problem hiding this comment.
If you not plan to fix it in tests now, I guess lets open a bug and solve it later - lets keep a good standard to avoid code duplication
losalex
approved these changes
Dec 5, 2022
Contributor
losalex
left a comment
There was a problem hiding this comment.
LGTM. Please open a bug for code duplication cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When client_info is not given to a new client, it now defaults to the values used by
self._connection._client_info, rather than using None. This will allow the expected headers to be populated when using the grpc transportAlso added tests to ensure client_info is always set as expected in all classes
Fixes #680