Conversation
When limit_to_last was set, we need to reverse the order. However due to error in comparing the order direction, it was not properly set. comparing `order.direction == self.ASCENDING` is always `False` because there are two different types. The correct way is by comparing `order.direction.name == self.ASCENDING` Fixes #536
triplequark
approved these changes
Feb 21, 2023
engelke
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When limit_to_last was set, we need to reverse the order. However due to error in comparing the order direction, it was not properly set.
comparing
order.direction == self.ASCENDINGis alwaysFalsebecause there are two different types.The correct way is by comparing
order.direction.name == self.ASCENDINGFixes #536
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕