Async Client Commit raises TypeError: Unexpected type of call <class 'google.cloud.firestore_v1.types.firestore.CommitResponse'> under emulator

[crwilcox]

branching from #64 (comment)

Thank you @mr-bjerre

Really appreciate the new support of AsyncClient !

One issue though. It doesn't work with the firestore emulator. The following script raises and exception

TypeError: Unexpected type of call <class 'google.cloud.firestore_v1.types.firestore.CommitResponse'>

Start the firestore emulator and run the script

import asyncio
from google.cloud.firestore import AsyncClient
import os


os.environ["FIRESTORE_EMULATOR_HOST"] = "localhost:8080"

client = AsyncClient()


async def save():
    return (
        await client.collection("test")
        .document("test")
        .set({"message": "Hello World!"})
    )


if __name__ == "__main__":
    loop = asyncio.get_event_loop()
    loop.run_until_complete(save())

The same issue goes for retrieving data.

[crwilcox]

Note, this only occurs under emulation.

[crwilcox]

Exception has occurred: TypeError
Unexpected type of call <class 'google.cloud.firestore_v1.types.firestore.CommitResponse'>
  File "/Users/crwilcox/workspace/python-firestore/google/cloud/firestore_v1/services/firestore/async_client.py", line 691, in commit
    response = await rpc(request, retry=retry, timeout=timeout, metadata=metadata,)
  File "/Users/crwilcox/workspace/python-firestore/google/cloud/firestore_v1/async_batch.py", line 58, in commit
    commit_response = await self._client._firestore_api.commit(
  File "/Users/crwilcox/workspace/python-firestore/google/cloud/firestore_v1/async_document.py", line 127, in set
    write_results = await batch.commit(**kwargs)
  File "/Users/crwilcox/scratch/python-firestore/watch.py", line 13, in document_set
    await async_client.collection("test").document("test").set({"message": "Hello World!"})
  File "/Users/crwilcox/scratch/python-firestore/watch.py", line 17, in <module>
    loop.run_until_complete(document_set())

[crwilcox]

I am marking this issue as external and have opened an issue against the api-core package. can close once resolved.

[joakimnordling]

Is there any estimation when we could see a release that would include the fix for this issue?