perf: decrease the threshold in which we use the BQ Storage Read API#1925
Merged
perf: decrease the threshold in which we use the BQ Storage Read API#1925
Conversation
shollyman
reviewed
May 21, 2024
google/cloud/bigquery/table.py
Outdated
| # In microbenchmarks, the first full page will be about 10 MB. If a page is | ||
| # about 2 MB, then it's the same speed or faster to download all the results | ||
| # using the BigQuery Storage Read API. | ||
| ALMOST_COMPLETELY_CACHED_RATIO = 10 / (10 + 2) |
Contributor
There was a problem hiding this comment.
I'm not sure I'm following the comment. In usage this appears to be a row ratio, but the comment is about response wire sizes? Also, should the value just remain a float literal? There's no parameter plugging in here.
Contributor
Author
There was a problem hiding this comment.
Updated the comment to explain more my methodology. Unfortunately, this heuristic isn't perfect, as it breaks down with large rows.
shollyman
approved these changes
May 21, 2024
Contributor
shollyman
left a comment
There was a problem hiding this comment.
Thanks for the clarifications
This was referenced May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕