fix: edit presubmit for to simplify configuration#1915
Merged
chalmerlowe merged 18 commits intomainfrom May 15, 2024
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
chalmerlowe
commented
May 10, 2024
chalmerlowe
commented
May 10, 2024
chalmerlowe
commented
May 10, 2024
Collaborator
Author
|
Using base names in the config file works fine. |
chalmerlowe
commented
May 14, 2024
1 task
shollyman
approved these changes
May 14, 2024
Contributor
shollyman
left a comment
There was a problem hiding this comment.
the title here seems out of sync with the changes, but I may be missing some context. It appears to simply be an update to the existing config, not a new one.
Linchin
approved these changes
May 14, 2024
This was referenced May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a new cfg that could be used in place of the existing kokoro presubmit test.
The intent here is to avoid using variables to skip certain nox sessions and simply call the nox sessions that we want to execute. The benefit is that...because nox sessions create the virtual env before they execute the session steps, we end up needlessly creating virtual envs for sessions that we end up skipping when we reach the skip/not skip logic.