docs: Updates query to query and wait in client_query_w_positional_params.py#1786
docs: Updates query to query and wait in client_query_w_positional_params.py#1786tswast merged 5 commits intogoogleapis:mainfrom
client_query_w_positional_params.py#1786Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
| ] | ||
| ) | ||
| query_job = client.query(query, job_config=job_config) # Make an API request. | ||
| query_job = client.query_and_wait( |
There was a problem hiding this comment.
Please rename this variable, as the return value is no longer a QueryJob object. Instead it is a RowIterator object. "rows" or "results" could be a good name.
There was a problem hiding this comment.
Yes, sounds good. Will correct that now.
| query, job_config=job_config | ||
| ) # Make an API request. | ||
|
|
||
| for row in query_job: |
There was a problem hiding this comment.
This line needs to be updated too. The query_job variable doesn't exist anymore.
There was a problem hiding this comment.
Yes, will correct now.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕