Repository navigation
feat: add pubsublite-kafka-auth module - #363
Merged
Merged
Conversation
|
Warning: This pull request is touching the following templated files:
|
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
dpcollins-google
force-pushed
the
kafka-auth
branch
2 times, most recently
from
December 6, 2022 21:48
cc63734 to
014b8cc
Compare
Contributor
There was a problem hiding this comment.
I did a pass. Other than the inline comments, could you add a short description for the Python script either in the README or in the file itself?
You probably need to break out the samples into a different PR after releasing the library with the change.
dpcollins-google
force-pushed
the
kafka-auth
branch
from
December 14, 2022 19:37
503d67e to
92684c6
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
from
December 14, 2022 23:41
51c0873 to
8a1c2d8
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
from
December 20, 2022 20:46
89d098d to
337ddec
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
2 times, most recently
from
December 20, 2022 21:27
a36b368 to
a3794e5
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
from
January 4, 2023 19:33
ecac518 to
7666f0e
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
from
January 4, 2023 20:50
9bc903c to
a267427
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
from
January 4, 2023 21:03
9a78df7 to
10d0024
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
from
January 4, 2023 21:18
99198c1 to
819584b
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
from
January 5, 2023 20:43
35d8b28 to
4732a37
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
from
January 5, 2023 21:28
5e92ae9 to
1acf38d
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
from
January 6, 2023 16:11
0e43e4c to
35b29ac
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
from
January 6, 2023 16:29
86c2151 to
958dfd9
Compare
dpcollins-google
force-pushed
the
kafka-auth
branch
from
January 6, 2023 17:12
f686952 to
322ac13
Compare
hannahrogers-google
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for auth through kafka params.