Skip to content

feat: add pubsublite-kafka-auth module - #363

Merged
dpcollins-google merged 26 commits into
mainfrom
kafka-auth
Jan 6, 2023
Merged

dpcollins-google merged 26 commits into
mainfrom
kafka-auth

Conversation

@dpcollins-google

@dpcollins-google dpcollins-google commented Nov 10, 2022 •

Copy link
Copy Markdown
Contributor

This allows for auth through kafka params.

@dpcollins-google dpcollins-google added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 10, 2022
@dpcollins-google
dpcollins-google requested review from a team November 10, 2022 21:28
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. labels Nov 10, 2022
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 6, 2022
@generated-files-bot

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@snippet-bot

snippet-bot Bot commented Dec 6, 2022 •

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dpcollins-google
dpcollins-google force-pushed the kafka-auth branch 2 times, most recently from cc63734 to 014b8cc Compare December 6, 2022 21:48
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022

@anguillanneuf anguillanneuf left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a pass. Other than the inline comments, could you add a short description for the Python script either in the README or in the file itself?

You probably need to break out the samples into a different PR after releasing the library with the change.

Comment thread samples/snippets/src/main/java/pubsublite/KafkaProducerExample.java Outdated
Comment thread pubsublite-kafka-auth/pom.xml Outdated
Comment thread samples/snippets/src/main/java/pubsublite/KafkaProducerExample.java Outdated
Comment thread samples/snippets/src/main/java/pubsublite/KafkaProducerExample.java Outdated
Comment thread kafka_gcp_credentials.py
@dpcollins-google dpcollins-google removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 14, 2022
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 20, 2022
@dpcollins-google
dpcollins-google force-pushed the kafka-auth branch 2 times, most recently from a36b368 to a3794e5 Compare December 20, 2022 21:27
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 20, 2022
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 20, 2022
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2023
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2023
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2023
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2023
@dpcollins-google dpcollins-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2023
@dpcollins-google
dpcollins-google merged commit 6c99767 into main Jan 6, 2023
@dpcollins-google
dpcollins-google deleted the kafka-auth branch January 6, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants