fix(bigquery): remove unnecessary warning #22904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
8fdd8c2 to
efa313b
Compare
Remove unnecessary warning in the console when optional `BIGQUERY_EMULATOR_HOST` env variable is not set. Restore backward compatibility with the behavior prior PR googleapis#22866
efa313b to
5f7bb6c
Compare
dazuma
approved these changes
Sep 7, 2023
|
thank you @spickermann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this PR removes the unnecessary
Invalid value nil for key :endpoint. Setting anyway.warning when the optional env variableBIGQUERY_EMULATOR_HOST(which was introduced in #22866) is not set.Allowing
nilin this case, enables backward compatibility with previous versions which setnilexplicitly and thereby triggered falling back to the default configuration without any warning message.closes: #22896