This repository was archived by the owner on May 12, 2026. It is now read-only.
Repository navigation
feat: adds universe domain for DownscopedCredentials and ExternalAccountAuthorizedUserCredentials - #1355
Merged
Conversation
lsirac
commented
Jan 18, 2024
Contributor
- Adds universe domain support for DownscopedCredentials.
- Adds universe domain support for ExternalAccountAuthorizedUserCredentials.
- Adds more tests for universe domain in the BYOID credential classes.
TimurSadykov
self-requested a review
January 20, 2024 00:54
|
looking |
TimurSadykov
suggested changes
Jan 22, 2024
aeitzman
approved these changes
Jan 23, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.