-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if files
doesn't resolve to a file
#1058
Comments
This seems like a good default, as it's usually an error, but I wonder about cases where a file might or might not be present, but it's still an input. We'd need a way to express that |
Good point. I wonder if letting the last character be If a string contains a |
could be an object? First option will throw error if no files found. Current syntax would work as it does now {
"files": [
{ "path": "src/**", "required": true },
"./some-generated-file.yml"
]
} |
Good defaults are important. I'd be open to using a literal to mark something as potentially missing, but string literals should be assumed to be real files. Optimize for the common case, not the outlier. |
makes sense. I was. thinking of situations where the output of one job is used as the input for another. I also was thinking about the error being a lint error not a runtime error (which re-reading the issue isn't correct). If that is the case swapping it around makes more sense {
"files": [
"src/**",
{ "path": "./some-generated-file.yml", "optional": true }
]
} |
files
leaves room for subtle mistakes that are hard to catch at review time, such as:If a literal path is specified that doesn't match an actual file, Wireit should throw an error.
See also #215
The text was updated successfully, but these errors were encountered: