Skip to content

Commit 09c78e0

Browse files
cushonError Prone Team
authored andcommitted
Remove an obsolete TODO
The javac bug is long fixed. I noticed this debugging b/451598162, but it's unrelated. PiperOrigin-RevId: 821649085
1 parent 17c271e commit 09c78e0

File tree

1 file changed

+3
-17
lines changed

1 file changed

+3
-17
lines changed

core/src/main/java/com/google/errorprone/bugpatterns/javadoc/InvalidLink.java

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import static com.google.errorprone.bugpatterns.javadoc.Utils.getStartPosition;
2525
import static com.google.errorprone.bugpatterns.javadoc.Utils.replace;
2626
import static com.google.errorprone.matchers.Description.NO_MATCH;
27-
import static com.google.errorprone.util.ErrorProneLog.deferredDiagnosticHandler;
2827

2928
import com.google.common.collect.ImmutableSet;
3029
import com.google.errorprone.BugPattern;
@@ -47,7 +46,6 @@
4746
import com.sun.tools.javac.api.JavacTrees;
4847
import com.sun.tools.javac.tree.DCTree.DCDocComment;
4948
import com.sun.tools.javac.tree.DCTree.DCText;
50-
import com.sun.tools.javac.util.Log;
5149
import java.util.regex.Matcher;
5250
import java.util.regex.Pattern;
5351
import javax.lang.model.element.Element;
@@ -145,21 +143,9 @@ public Void visitLink(LinkTree linkTree, Void unused) {
145143
return super.visitLink(linkTree, null);
146144
}
147145
String reference = linkTree.getReference().getSignature();
148-
Element element = null;
149-
Log log = Log.instance(state.context);
150-
// Install a deferred diagnostic handler before calling DocTrees.getElement(DocTreePath)
151-
// TODO(cushon): revert if https://bugs.openjdk.java.net/browse/JDK-8248117 is fixed
152-
Log.DeferredDiagnosticHandler deferredDiagnosticHandler = deferredDiagnosticHandler(log);
153-
try {
154-
element =
155-
JavacTrees.instance(state.context)
156-
.getElement(new DocTreePath(getCurrentPath(), linkTree.getReference()));
157-
} catch (NullPointerException | AssertionError e) {
158-
// TODO(b/176098078): remove once JDK 12 is the minimum supported version
159-
// https://bugs.openjdk.java.net/browse/JDK-8200432
160-
} finally {
161-
log.popDiagnosticHandler(deferredDiagnosticHandler);
162-
}
146+
Element element =
147+
JavacTrees.instance(state.context)
148+
.getElement(new DocTreePath(getCurrentPath(), linkTree.getReference()));
163149
// Don't warn about fully qualified types; they won't always be known at compile-time.
164150
if (element != null || reference.contains(".")) {
165151
return super.visitLink(linkTree, null);

0 commit comments

Comments
 (0)