Skip to content

Make App Check core availability for all supported platforms - #8388

Merged
maksymmalyhin merged 11 commits into
masterfrom
mm/app-check-availability
Jul 15, 2021
Merged

maksymmalyhin merged 11 commits into
masterfrom
mm/app-check-availability

Conversation

@maksymmalyhin

@maksymmalyhin maksymmalyhin commented Jul 14, 2021 •

Copy link
Copy Markdown
Contributor

b/193554541

  • App Check SDK availability now matches to Firebase Core availability
  • App Attest and DeviceCheck providers availability matches the underlying platform API availability (see DCDevice and DCAppAttestService)

@maksymmalyhin
maksymmalyhin marked this pull request as ready for review July 14, 2021 21:56

@ncooke3 ncooke3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRAppCheckAvailability.h Outdated
Comment thread FirebaseAppCheck.podspec Outdated
Comment thread FirebaseAppCheck/Tests/Unit/Swift/AppCheckAPITests.swift Outdated
Comment thread FirebaseAppCheck/Tests/Unit/Core/FIRAppCheckIntegrationTests.m Outdated
@maksymmalyhin

Copy link
Copy Markdown
Contributor Author

I'm merging it soon, but feel free to left more comments to address in followup PRs.

@maksymmalyhin
maksymmalyhin merged commit 85c42dc into master Jul 15, 2021
@maksymmalyhin
maksymmalyhin deleted the mm/app-check-availability branch July 15, 2021 20:41
@firebase firebase locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants