Add support for testing in-app messages in SwiftUI previews#8351
Merged
christibbs merged 23 commits intomasterfrom Jul 16, 2021
Merged
Add support for testing in-app messages in SwiftUI previews#8351christibbs merged 23 commits intomasterfrom
christibbs merged 23 commits intomasterfrom
Conversation
…in unit testing or SwiftUI previews
…nly include parameters that effect layout
…per methods for generating mock messages
Collaborator
Coverage ReportAffected SDKs
Test Logs |
ryanwilson
reviewed
Jul 12, 2021
Contributor
Author
|
@ryanwilson Resolved all open items, PTAL! |
ryanwilson
approved these changes
Jul 16, 2021
Member
ryanwilson
left a comment
There was a problem hiding this comment.
Just a couple small things with the xcproject but otherwise LGTM. Thanks!
ryanwilson
approved these changes
Jul 16, 2021
This was referenced Jul 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In core FIAM SDK: Opens up initializers for image subclasses
FirebaseInAppMessaging/Sources/Public/FirebaseInAppMessaging/FIRInAppMessagingRendering.hIn core FIAM UI test project, refactor to use open message initializers
FirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/BannerMessageViewController.swiftFirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/ImageOnlyMessageViewController.swiftFirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/ModalMessageViewController.swiftFirebaseInAppMessaging/Tests/Integration/DefaultUITestApp/FiamDisplaySwiftExample/CardMessageViewController.swiftIn FIAM SwiftUI SDK: Adds preview helper methods to create canned in-app messages
FirebaseInAppMessaging/Swift/Source/SwiftUIPreviewHelpers.swiftIn FIAM SwiftUI integration test project: Updates project to use SwiftUI preview helpers
FirebaseInAppMessaging/Swift/Tests/Integration/FIAMSwiftUI/Shared/ModalInAppMessageView.swift