Only fail a StorageTask once - #5245
Merged
Merged
Conversation
Member
|
LGTM, please wait for @schmidt-sebastian's review |
ryanwilson
approved these changes
Apr 1, 2020
schmidt-sebastian
approved these changes
Apr 1, 2020
schmidt-sebastian
left a comment
Contributor
There was a problem hiding this comment.
LGTM, though I wonder if this should be a "completed" state and shared between FIRStorageTaskStatusSuccess and FIRStorageTaskStatusFailure.
Member
Author
|
@schmidt-sebastian I changed it to a |
schmidt-sebastian
approved these changes
Apr 1, 2020
schmidt-sebastian
left a comment
Contributor
There was a problem hiding this comment.
Storage is receiving so much love this week! Thanks.
| @@ -1,3 +1,7 @@ | |||
| # Unreleased | |||
| - [fixed] Fix the rare case where a StorageTask would call its completion callbacks more than | |||
pranavrajgopal
pushed a commit
that referenced
this pull request
Apr 8, 2020
ryanwilson
pushed a commit
that referenced
this pull request
Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix an occasional flake I was seeing in testUnauthenticatedSimpleGetDataTooSmall where the expectation was getting fulfilled twice.