Add SIGTERM support - #12881
Merged
Merged
Add SIGTERM support#12881
Conversation
Member
|
Hi @naftaly, thanks for the PR! There is one CI failure: https://github.com/firebase/firebase-ios-sdk/actions/runs/8913792847/job/24481253930?pr=12881 This can be fixed by running the style script. It looks like just a trailing whitespace. |
themiswang
approved these changes
May 1, 2024
themiswang
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the PR @naftaly, LGTM!
ncooke3
added a commit
that referenced
this pull request
May 2, 2024
ncooke3
added a commit
that referenced
this pull request
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for catching the SIGTERM signal.
All Apple OS's send SIGTERM (like any good unix based system) when they want to request a graceful termination of an application, when the app doesn't quit in those circumstances, it'll receive a SIGKILL. This often gives us the opportunity to get a stack trace where we know Apple wants the app to be terminated but don't know why (watchdog events). This is just one more piece of information that can be added to the puzzle of figuring out unexplained app terminations.
Example in the Firebase Console:
