Recaptcha integration master pr by renkelvin · Pull Request #11231 · firebase/firebase-ios-sdk

renkelvin · 2023-05-04T22:16:21Z

No description provided.

google-oss-bot · 2023-05-04T22:17:51Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

)

…et password (#11446)

github-actions · 2023-07-18T20:46:12Z

Apple API Diff Report

Commit: 5bfdd58
Last updated: Tue Jul 25 13:21 PDT 2023
View workflow logs & download artifacts

FirebaseAuth

Enumerations

FIRAuthErrorCode

[ADDED] FIRAuthErrorCodeMissingRecaptchaVersion

Swift:
+  case missingRecaptchaVersion = 17205
Objective-C:
+  FIRAuthErrorCodeMissingRecaptchaVersion = 17205

[ADDED] FIRAuthErrorCodeRecaptchaNotEnabled

Swift:
+  case recaptchaNotEnabled = 17200
Objective-C:
+  FIRAuthErrorCodeRecaptchaNotEnabled = 17200

[ADDED] FIRAuthErrorCodeInvalidReqType

Swift:
+  case invalidReqType = 17207
Objective-C:
+  FIRAuthErrorCodeInvalidReqType = 17207

[ADDED] FIRAuthErrorCodeMissingClientType

Swift:
+  case missingClientType = 17204
Objective-C:
+  FIRAuthErrorCodeMissingClientType = 17204

[ADDED] FIRAuthErrorCodeInvalidRecaptchaToken

Swift:
+  case invalidRecaptchaToken = 17202
Objective-C:
+  FIRAuthErrorCodeInvalidRecaptchaToken = 17202

[ADDED] FIRAuthErrorCodeRecaptchaSDKNotLinked

Swift:
+  case recaptchaSDKNotLinked = 17208
Objective-C:
+  FIRAuthErrorCodeRecaptchaSDKNotLinked = 17208

[ADDED] FIRAuthErrorCodeMissingRecaptchaToken

Swift:
+  case missingRecaptchaToken = 17201
Objective-C:
+  FIRAuthErrorCodeMissingRecaptchaToken = 17201

[ADDED] FIRAuthErrorCodeInvalidRecaptchaVersion

Swift:
+  case invalidRecaptchaVersion = 17206
Objective-C:
+  FIRAuthErrorCodeInvalidRecaptchaVersion = 17206

[ADDED] FIRAuthErrorCodeInvalidRecaptchaAction

Swift:
+  case invalidRecaptchaAction = 17203
Objective-C:
+  FIRAuthErrorCodeInvalidRecaptchaAction = 17203

[MODIFIED] FIRAuthErrorCodeMissingClientIdentifier

Swift:
+  case missingClientIdentifier = 17093
-  case missingClientIdentifier = 17993
Objective-C:
+  FIRAuthErrorCodeMissingClientIdentifier = 17093
-  FIRAuthErrorCodeMissingClientIdentifier = 17993

google-oss-bot · 2023-07-18T21:48:31Z

Coverage Report ¹

Affected Products

`FirebaseAuth-iOS-FirebaseAuth.framework`

Overall coverage changed from 68.90% (1efcabf) to 67.63% (5bfdd58) by -1.27%.

12 individual files with coverage change

Filename	Base (`1efcabf`)	Merge (`5bfdd58`)	Diff
FIRAuth.m	80.49%	78.54%	-1.95%
FIRAuthBackend.m	82.20%	81.92%	-0.28%
FIRAuthErrorUtils.m	72.27%	68.26%	-4.01%
FIRAuthRecaptchaVerifier.m	?	11.25%	?
FIRFinalizeMFAEnrollmentRequest.m	64.29%	65.00%	+0.71%
FIRFinalizeMFASignInRequest.m	87.50%	87.10%	-0.40%
FIRGetOOBConfirmationCodeRequest.m	84.91%	86.55%	+1.65%
FIRGetRecaptchaConfigRequest.m	?	77.27%	?
FIRGetRecaptchaConfigResponse.m	?	100.00%	?
FIRSignUpNewUserRequest.m	94.44%	95.92%	+1.47%
FIRStartMFAEnrollmentRequest.m	62.16%	62.86%	+0.69%
FIRVerifyPasswordRequest.m	94.12%	95.45%	+1.34%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/K4hegamXxA.html

Co-Authored-By: Kevin Cheung <kevinthecheung@users.noreply.github.com>

This fixes compile errors that result from some method renamings in #11231 Signed-off-by: Peter Friese <peter@peterfriese.de>

#11231 introduces some renamed methods, which broke the Combine build, see this workflow run: firebase/firebase-ios-sdk/actions/runs/5665691823 This PR should fix this.

This reverts commit 032abb4.

Reverted reCAPTCHA <-> Auth integration PRs (#11231, #11606, #11609, #11610) due to an issue with the zip build.

chuanr added 5 commits May 4, 2023 14:45

Implement get recaptcha config (#10038)

affb496

Add recaptcha related errors (#10048)

efe9db1

Backend apis (#10063)

cdbad71

Expose only needed error codes (#10635)

cdedffe

Rebase to current master

81a12fa

google-oss-bot added api: auth public-api-change labels May 4, 2023

renkelvin added 3 commits June 12, 2023 10:24

Implement recaptcha verification flow for email password sign in (#10670

835dbbc

)

Add reCAPTCHA support to email flows of sign up, send email link, res…

9424622

…et password (#11446)

Merge branch 'master' into recaptcha

9af06c3

github-actions Bot removed the public-api-change label Jul 18, 2023

google-oss-bot added the public-api-change label Jul 18, 2023

github-actions Bot removed the public-api-change label Jul 18, 2023

google-oss-bot added the public-api-change label Jul 18, 2023

github-actions Bot removed the public-api-change label Jul 18, 2023

google-oss-bot added the public-api-change label Jul 18, 2023

github-actions Bot removed the public-api-change label Jul 19, 2023

google-oss-bot added the public-api-change label Jul 19, 2023

github-actions Bot removed the public-api-change label Jul 19, 2023

google-oss-bot added the public-api-change label Jul 19, 2023

github-actions Bot removed the public-api-change label Jul 19, 2023

google-oss-bot added the public-api-change label Jul 19, 2023

github-actions Bot added public-api-change and removed public-api-change labels Jul 19, 2023

Changes post rebase

8170722

renkelvin force-pushed the recaptcha branch from 52796a3 to 8170722 Compare July 19, 2023 22:12

github-actions Bot removed the public-api-change label Jul 19, 2023

github-actions Bot removed the public-api-change label Jul 24, 2023

google-oss-bot added the public-api-change label Jul 24, 2023

prameshj reviewed Jul 24, 2023

View reviewed changes

Address pr issues

24d0944

github-actions Bot removed the public-api-change label Jul 24, 2023

google-oss-bot added the public-api-change label Jul 24, 2023

prameshj approved these changes Jul 24, 2023

View reviewed changes

Comment thread FirebaseAuth/Sources/Utilities/FIRAuthRecaptchaVerifier.m

Comment thread FirebaseAuth/Sources/Utilities/FIRAuthRecaptchaVerifier.m Outdated

Update FIRAuthRecaptchaVerifier.m

d436fdc

github-actions Bot removed the public-api-change label Jul 25, 2023

google-oss-bot added the public-api-change label Jul 25, 2023

kevinthecheung reviewed Jul 25, 2023

View reviewed changes

github-actions Bot added public-api-change and removed public-api-change labels Jul 25, 2023

Update docs

c74cedb

Co-Authored-By: Kevin Cheung <kevinthecheung@users.noreply.github.com>

renkelvin force-pushed the recaptcha branch from 6cfdad6 to c74cedb Compare July 25, 2023 20:18

github-actions Bot removed the public-api-change label Jul 25, 2023

google-oss-bot added the public-api-change label Jul 25, 2023

kevinthecheung approved these changes Jul 25, 2023

View reviewed changes

renkelvin merged commit 032abb4 into master Jul 25, 2023

renkelvin deleted the recaptcha branch July 25, 2023 21:32

peterfriese added a commit that referenced this pull request Jul 26, 2023

Fix compile errors in Combine

8786303

This fixes compile errors that result from some method renamings in #11231 Signed-off-by: Peter Friese <peter@peterfriese.de>

peterfriese mentioned this pull request Jul 26, 2023

Fix compile errors in Combine #11610

Merged

andrewheard pushed a commit that referenced this pull request Jul 26, 2023

Fix compile errors in Combine (#11610)

959cf0d

#11231 introduces some renamed methods, which broke the Combine build, see this workflow run: firebase/firebase-ios-sdk/actions/runs/5665691823 This PR should fix this.

renkelvin pushed a commit that referenced this pull request Jul 26, 2023

Revert "Recaptcha integration master pr (#11231)"

6a919b1

This reverts commit 032abb4.

renkelvin mentioned this pull request Jul 26, 2023

Revert "Recaptcha integration master pr" #11616

Closed

andrewheard added a commit that referenced this pull request Jul 26, 2023

Revert "Recaptcha integration master pr (#11231)"

d74281a

This reverts commit 032abb4.

andrewheard added a commit that referenced this pull request Jul 26, 2023

[Auth] Revert reCAPTCHA integration PRs (#11617)

24c9cba

Reverted reCAPTCHA <-> Auth integration PRs (#11231, #11606, #11609, #11610) due to an issue with the zip build.

firebase locked and limited conversation to collaborators Aug 25, 2023

Conversation

renkelvin commented May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-oss-bot commented May 4, 2023

Uh oh!

github-actions Bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Apple API Diff Report

FirebaseAuth

Enumerations

FIRAuthErrorCode

Uh oh!

google-oss-bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

FirebaseAuth-iOS-FirebaseAuth.framework

Test Logs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

renkelvin commented May 4, 2023 •

edited

Loading

github-actions Bot commented Jul 18, 2023 •

edited

Loading

google-oss-bot commented Jul 18, 2023 •

edited

Loading

Coverage Report ¹

`FirebaseAuth-iOS-FirebaseAuth.framework`