Commit ceb8392
authored
Add warning for deprecated API to indicate that the passed in domain name's scheme will deduced as https (#2078)
* Add support for creating DL with custom domain names/paths. The new domainURIPrefix parameter requires either a. a valid FDL domain name created in the Firebase console or b. a custom domain name or c. a custom domain name with path registered for DL. All domainURIPrefixes need to start with a valid (https) scheme.
* Fix style.
* style
* Fix typo in DEPRECATED_MSG_ATTRIBUTE, other nits.
* Fix styling.
* Check incoming domainURIPrefix for validity using NSURL and check for an https scheme.
* Add extra checks for deprecated domain parameter being incorrectly called with a scheme. Also fix some nits.
* Log a warning for the deprecated API stating that the scheme for the supplied domain will be deduced as https.
* Update CHANGELOG for M38.
* Update changelog for M38
* Update CHANGELOG for M38 release.
* Capitalize HTTPS.
* Update CHANGELOG to include PR for removal of deprecated files.
* Capitalize HTTPS.1 parent cda79a8 commit ceb8392
4 files changed
Lines changed: 17 additions & 5 deletions
File tree
- Firebase/DynamicLinks
- FDLURLComponents
- Logging
- Public
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
Lines changed: 10 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
452 | 452 | | |
453 | 453 | | |
454 | 454 | | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
455 | 459 | | |
456 | 460 | | |
457 | 461 | | |
458 | 462 | | |
459 | 463 | | |
460 | 464 | | |
461 | 465 | | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
462 | 470 | | |
463 | 471 | | |
464 | 472 | | |
| |||
472 | 480 | | |
473 | 481 | | |
474 | 482 | | |
475 | | - | |
| 483 | + | |
476 | 484 | | |
477 | 485 | | |
478 | 486 | | |
| |||
491 | 499 | | |
492 | 500 | | |
493 | 501 | | |
494 | | - | |
| 502 | + | |
495 | 503 | | |
496 | 504 | | |
497 | 505 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
512 | 512 | | |
513 | 513 | | |
514 | 514 | | |
515 | | - | |
| 515 | + | |
| 516 | + | |
516 | 517 | | |
517 | 518 | | |
518 | 519 | | |
| |||
527 | 528 | | |
528 | 529 | | |
529 | 530 | | |
530 | | - | |
| 531 | + | |
| 532 | + | |
531 | 533 | | |
532 | 534 | | |
533 | 535 | | |
| |||
0 commit comments