Skip to content

Commit bbf24ad

Browse files
szedergitster
authored andcommitted
travis-ci: don't be '--quiet' when running the tests
All Travis CI build jobs run the test suite with 'make --quiet test'. On one hand, being quiet doesn't save us from much clutter in the output: $ make test |wc -l 861 $ make --quiet test |wc -l 848 It only spares 13 lines, mostly the output of entering the 't/' directory and the pre- and post-cleanup commands, which is negligible compared to the ~700 lines printed while building Git and the ~850 lines of 'prove' output. On the other hand, it's asking for trouble. In our CI build scripts we build Git and run the test suite in two separate 'make' invocations. In a prelimiary version of one of the later patches in this series, to explicitly specify which compiler to use, I changed them to basically run: make CC=$CC make --quiet test naively thinking that it should Just Work... but then that 'make --quiet test' got all clever on me, noticed the changed build flags, and then proceeded to rebuild everything with the default 'cc'. And because of that '--quiet' option, it did so, well, quietly, only saying "* new build flags", and it was by mere luck that I happened to notice that something is amiss. Let's just drop that '--quiet' option when running the test suite in all build scripts. Signed-off-by: SZEDER Gábor <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent ff0eec9 commit bbf24ad

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

ci/run-build-and-tests.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
ln -s "$cache_dir/.prove" t/.prove
99

1010
make --jobs=2
11-
make --quiet test
11+
make test
1212
if test "$jobname" = "linux-gcc"
1313
then
1414
export GIT_TEST_SPLIT_INDEX=yes
@@ -17,7 +17,7 @@ then
1717
export GIT_TEST_OE_DELTA_SIZE=5
1818
export GIT_TEST_COMMIT_GRAPH=1
1919
export GIT_TEST_MULTI_PACK_INDEX=1
20-
make --quiet test
20+
make test
2121
fi
2222

2323
check_unignored_build_artifacts

ci/run-linux32-build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,5 @@ linux32 --32bit i386 su -m -l $CI_USER -c '
5656
cd /usr/src/git
5757
test -n "$cache_dir" && ln -s "$cache_dir/.prove" t/.prove
5858
make --jobs=2
59-
make --quiet test
59+
make test
6060
'

0 commit comments

Comments
 (0)