Skip to content

The thirdparty/asio submodule is not included in your release tarballs #6323

@asymingt

Description

@asymingt

Is there an already existing issue for this?

  • I have searched the existing issues

Expected behavior

The thirdparty/asio folder in the release has files.

Current behavior

The thirdparty/asio folder in the release has no files.

Steps to reproduce

Download a release and look in the thirdparty/asio folder.

Fast DDS version/commit

All release archives are affected.

Platform/Architecture

Other. Please specify in Additional context section.

Transport layer

Default configuration, UDPv4 & SHM

Additional context

I am writing a bazel module to build fastdds@3.5.0. The trouble is that when you build with HAVE_SECURITY=1 you need asio from the thirdparty folder. However that doesn't exist in your archive.

This is the main issue tracking the submodule exclusion problem in github:
dear-github/dear-github#214

The simplest path forward would likely be a github action that runs when a new tag is pushed, and this action pulls the submodules recursively, strips out all git metadata and compresses release zip and tar.gz archives.

XML configuration file

Relevant log output

Network traffic capture

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageIssue pending classification

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions