Suppress IL3050 warnings (#110340)

sbomer · MichalStrehovsky · web-flow · commit 87916eef87e2 · 2024-12-03T10:21:12.000-08:00
Co-authored-by: Michal Strehovský &lt;MichalStrehovsky@users.noreply.github.com&gt;
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/Reflection/ExpressionCallString.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/Reflection/ExpressionCallString.cs
@@ -10,6 +10,8 @@ namespace Mono.Linker.Tests.Cases.Reflection
 	[Reference ("System.Core.dll")]
 	[ExpectedNoWarnings]
 	[KeptPrivateImplementationDetails ("ThrowSwitchExpressionException")]
+	[KeptAttributeAttribute(typeof(UnconditionalSuppressMessageAttribute))]
+	[UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]
 	public class ExpressionCallString
 	{
 		public static void Main ()
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/Reflection/ExpressionCallStringAndLocals.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/Reflection/ExpressionCallStringAndLocals.cs
@@ -1,4 +1,5 @@
 ﻿using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq.Expressions;
 using Mono.Linker.Tests.Cases.Expectations.Assertions;
 using Mono.Linker.Tests.Cases.Expectations.Metadata;
@@ -7,6 +8,8 @@ namespace Mono.Linker.Tests.Cases.Reflection
 {
 	[Reference ("System.Core.dll")]
 	[ExpectedNoWarnings]
+	[KeptAttributeAttribute (typeof (UnconditionalSuppressMessageAttribute))]
+	[UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]
 	public class ExpressionCallStringAndLocals
 	{
 		public static void Main ()
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/WarningSuppression/AddSuppressionsBeforeAttributeRemoval.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/WarningSuppression/AddSuppressionsBeforeAttributeRemoval.cs
@@ -9,6 +9,7 @@ namespace Mono.Linker.Tests.Cases.Warnings.WarningSuppression
 	[SetupLinkAttributesFile ("AddSuppressionsBeforeAttributeRemoval.xml")]
 
 	[ExpectedNoWarnings]
+	[UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]
 	public class AddSuppressionsBeforeAttributeRemoval
 	{
 		[Kept]
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/WarningSuppression/DetectRedundantSuppressionsFeatureSubstitutions.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/WarningSuppression/DetectRedundantSuppressionsFeatureSubstitutions.cs
@@ -13,6 +13,7 @@ namespace Mono.Linker.Tests.Cases.Warnings.WarningSuppression
 	[SetupLinkerArgument ("--feature", "Feature", "false")]
 	[ExpectedNoWarnings]
 	[SkipKeptItemsValidation]
+	[UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]
 	public class DetectRedundantSuppressionsFeatureSubstitutions
 	{
 		public static void Main ()
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/WarningSuppression/DetectRedundantSuppressionsInMembersAndTypes.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/WarningSuppression/DetectRedundantSuppressionsInMembersAndTypes.cs
@@ -10,6 +10,7 @@ namespace Mono.Linker.Tests.Cases.Warnings.WarningSuppression
 {
 	[ExpectedNoWarnings]
 	[SkipKeptItemsValidation]
+	[UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]
 	public class DetectRedundantSuppressionsInMembersAndTypes
 	{
 		public static void Main ()
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/WarningSuppression/DetectRedundantSuppressionsTrimmedMembersTarget.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/WarningSuppression/DetectRedundantSuppressionsTrimmedMembersTarget.cs
@@ -23,6 +23,7 @@ namespace Mono.Linker.Tests.Cases.Warnings.WarningSuppression
 {
 	[ExpectedNoWarnings]
 	[SkipKeptItemsValidation]
+	[UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]
 	class DetectRedundantSuppressionsTrimmedMembersTarget
 	{
 		[ExpectedWarning ("IL2072")]
diff --git a/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/WarningSuppression/SuppressWarningsInMembersAndTypesUsingTarget.cs b/src/tools/illink/test/Mono.Linker.Tests.Cases/Warnings/WarningSuppression/SuppressWarningsInMembersAndTypesUsingTarget.cs
@@ -17,6 +17,7 @@ namespace Mono.Linker.Tests.Cases.Warnings.WarningSuppression
 #endif
 	[SkipKeptItemsValidation]
 	[LogDoesNotContain ("TriggerUnrecognizedPattern()")]
+	[UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]
 	public class SuppressWarningsInMembersAndTypesUsingTarget
 	{
 		/// <summary>
@@ -83,6 +84,7 @@ void Warning4 ()
 	}
 
 	[ExpectedNoWarnings]
+	[UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]
 	public class WarningsInMembers
 	{
 		public void Method ()

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,8 @@ namespace Mono.Linker.Tests.Cases.Reflection`
`10`	`10`	`[Reference ("System.Core.dll")]`
`11`	`11`	`[ExpectedNoWarnings]`
`12`	`12`	`[KeptPrivateImplementationDetails ("ThrowSwitchExpressionException")]`
	`13`	`+ [KeptAttributeAttribute(typeof(UnconditionalSuppressMessageAttribute))]`
	`14`	`+ [UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]`
`13`	`15`	`public class ExpressionCallString`
`14`	`16`	`{`
`15`	`17`	`public static void Main ()`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`using System;`
	`2`	`+using System.Diagnostics.CodeAnalysis;`
`2`	`3`	`using System.Linq.Expressions;`
`3`	`4`	`using Mono.Linker.Tests.Cases.Expectations.Assertions;`
`4`	`5`	`using Mono.Linker.Tests.Cases.Expectations.Metadata;`
`@@ -7,6 +8,8 @@ namespace Mono.Linker.Tests.Cases.Reflection`
`7`	`8`	`{`
`8`	`9`	`[Reference ("System.Core.dll")]`
`9`	`10`	`[ExpectedNoWarnings]`
	`11`	`+ [KeptAttributeAttribute (typeof (UnconditionalSuppressMessageAttribute))]`
	`12`	`+ [UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]`
`10`	`13`	`public class ExpressionCallStringAndLocals`
`11`	`14`	`{`
`12`	`15`	`public static void Main ()`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ namespace Mono.Linker.Tests.Cases.Warnings.WarningSuppression`
`9`	`9`	`[SetupLinkAttributesFile ("AddSuppressionsBeforeAttributeRemoval.xml")]`
`10`	`10`
`11`	`11`	`[ExpectedNoWarnings]`
	`12`	`+ [UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]`
`12`	`13`	`public class AddSuppressionsBeforeAttributeRemoval`
`13`	`14`	`{`
`14`	`15`	`[Kept]`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ namespace Mono.Linker.Tests.Cases.Warnings.WarningSuppression`
`13`	`13`	`[SetupLinkerArgument ("--feature", "Feature", "false")]`
`14`	`14`	`[ExpectedNoWarnings]`
`15`	`15`	`[SkipKeptItemsValidation]`
	`16`	`+ [UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]`
`16`	`17`	`public class DetectRedundantSuppressionsFeatureSubstitutions`
`17`	`18`	`{`
`18`	`19`	`public static void Main ()`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ namespace Mono.Linker.Tests.Cases.Warnings.WarningSuppression`
`10`	`10`	`{`
`11`	`11`	`[ExpectedNoWarnings]`
`12`	`12`	`[SkipKeptItemsValidation]`
	`13`	`+ [UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]`
`13`	`14`	`public class DetectRedundantSuppressionsInMembersAndTypes`
`14`	`15`	`{`
`15`	`16`	`public static void Main ()`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ namespace Mono.Linker.Tests.Cases.Warnings.WarningSuppression`
`23`	`23`	`{`
`24`	`24`	`[ExpectedNoWarnings]`
`25`	`25`	`[SkipKeptItemsValidation]`
	`26`	`+ [UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]`
`26`	`27`	`class DetectRedundantSuppressionsTrimmedMembersTarget`
`27`	`28`	`{`
`28`	`29`	`[ExpectedWarning ("IL2072")]`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ namespace Mono.Linker.Tests.Cases.Warnings.WarningSuppression`
`17`	`17`	`#endif`
`18`	`18`	`[SkipKeptItemsValidation]`
`19`	`19`	`[LogDoesNotContain ("TriggerUnrecognizedPattern()")]`
	`20`	`+ [UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]`
`20`	`21`	`public class SuppressWarningsInMembersAndTypesUsingTarget`
`21`	`22`	`{`
`22`	`23`	`/// <summary>`
`@@ -83,6 +84,7 @@ void Warning4 ()`
`83`	`84`	`}`
`84`	`85`
`85`	`86`	`[ExpectedNoWarnings]`
	`87`	`+ [UnconditionalSuppressMessage ("AOT", "IL3050", Justification = "These tests are not targeted at AOT scenarios")]`
`86`	`88`	`public class WarningsInMembers`
`87`	`89`	`{`
`88`	`90`	`public void Method ()`