Dendron should ignore lookupConfirmVaultOnCreate when dailyVault is set

[djradon]

Please select the area your Bug applys to. (Multiple selections are Possible)

• Onboard. Initial vault setup and import/export pods
• Create. Note creation, lookup, snippets and templates
• Retrieve. Backlinks, references, graph view
• Structure. Refactoring, multi-vault and schemas
• Publish. Sharing your repo with the world
• Misc (Choose this if your not sure)

Describe the bug

If a user has set a default vault with dailyVault for Daily Journal Notes, they should be created there without prompt. But if lookupConfirmVaultOnCreate is true, then dailyVault is ignored and the user is prompted for a vault.

To Reproduce

1. specify a default vault with journal: dailyVault in dendron.yml
2. ensure lookupConfirmVaultOnCreate: true
3. trigger "Dendron: Create Daily Journal Note"
4. vault prompt appears

Expected behavior

Note should be created in specified vault without a prompt

Desktop (please complete the following information)

• Windows VSCode
• Dendron0.58.0

Additional context

https://discord.com/channels/717965437182410783/735365126227493004/882141048019746847

[jonathanyeung]

Thanks @djradon - this suggestion makes sense; the precedence of dailyVault default should override lookupConfirmVaultOnCreate.

The fix should be relatively straightforward; I'm adding the size.small tag in case anyone wants to give it a try.

The relevant code for modification should be here

dendron/packages/plugin-core/src/commands/CreateDailyJournal.ts

Line 53 in 66111a1

if (config.lookupConfirmVaultOnCreate) {

[Harshita-mindfire]

This should be fixed in v0.59 of Dendron. Please post here if not, otherwise this issue will auto close in 4 days

[no-response]

This issue has been automatically closed because there has been no response to our request for more information from the original author. We don't have enough information to take action. Please reopen if the question from the maintainer has been answered and the issue is still valid.