Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: add build flag so can handle more open files #775

Closed
fxfactorial opened this issue Feb 6, 2025 · 3 comments
Closed

Comments

@fxfactorial
Copy link

Feature request description

please add

CFLAGS="-DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT"

to the build flags see: https://en.liujiacai.net/2022/09/03/emacs-maxopenfiles/

@dakra
Copy link

dakra commented Feb 7, 2025

It's already set, e.g.

ENV.append "CFLAGS", "-O2 -DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT"

@fxfactorial
Copy link
Author

fxfactorial commented Feb 7, 2025

darn - I still run out of files - is it possible @d12frosted to bump it up even more or expose it in the build flags , something --with-fd-size=..

@d12frosted
Copy link
Owner

@fxfactorial I am not sure it's a good idea to increase this limit even further, need to check with macos limits. Adding an option is not an option (pun not intended), because brew supports only boolean options. An alternative would be to `brew edit emacs-plus@30 (or whatever version you are using) and edit that number yourself before building Emacs again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants