Breaking change in 0.1.7

[twdrake-ap]

knex not initializing correctly, still looking into details

fyi

[cvburgess]

damn - im sorry - ill investigate as well - please report anything you find

[cvburgess]

what db driver are you using?

[cvburgess]

ive tested with PG and SQLite and have no issues... this is probably affecting some users:

https://github.com/cvburgess/SQLDataSource/pull/11/files#diff-bcfcedf7cec98b0d2b60ca67f7881b43R13

I do not have test cases around:

• mysql
• mysql2
• oracledb
• redshift

And in 0.1.7 they defaulted to the no-unwraping logic... which may be incorrect

[twdrake-ap]

We are using PG with knex v0.16.5

[cvburgess]

Hmm i dont have that issue with Knex and PG - can you create a code sandbox or similar to help me debug?

[jgoslow]

I'm also getting this error:

error on getClient TypeError: Cannot read property 'knex' of undefined
at normalizeDBResult (/usr/src/app/node_modules/datasource-sql/SQLCache.js:14:18)
at <anonymous>

Going back to ver 0.1.6 fixed it.

Seems that the changes to the getBatched function there are not passing the this.knex object properly into the normalizeDBResult function.

[a2exfr]

@Igoslow Hi I think this line should be
return this.loader.load(queryString).then(result => this.normalizeDBResult(result));

Also I found that I need to chage this line
to
switch (this.knex.client.config.client)

but I rewrite it for my needs.

Another important thing for me, is to return parsed result from db, not raw responce from db driver(that is returned now), if this needed feature I can make pr.

[cvburgess]

@a2exfr What DB driver are you using?

[a2exfr]

@cvburgess I use MySQL as the DB. This is knex raw method feature.

[cvburgess]

Awesome! Can you open a PR that adds MySQL support - the line code for driver-level editing of the raw response is here:

https://github.com/cvburgess/SQLDataSource/blob/master/SQLCache.js#L22-L23

[cvburgess]

@jgoslow i think this may be related to your node version? Can i get more information about your env?

[jgoslow]

Sure no problem. Node version 8.12.0

…

On Mon, May 20, 2019 at 2:11 PM Charles Burgess ***@***.***> wrote: @jgoslow <https://github.com/jgoslow> i think this may be related to your node version? Can i get more information about your env? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19?email_source=notifications&email_token=ACANBCWR42TYNNNCX3UXKFLPWMHWXA5CNFSM4HIHG3B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV2CW3Y#issuecomment-494152559>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACANBCVNWI2DPUEZ2QZRWDDPWMHWXANCNFSM4HIHG3BQ> .

-- *Jonas Goslow* jonas@lyradesigns.com *612-203-9184*