From 1718b2ed78c97a8542084dc48b53550ddcd60b9d Mon Sep 17 00:00:00 2001 From: Shaleen Date: Tue, 22 Sep 2020 22:52:32 +0530 Subject: [PATCH 1/4] Fixed filename bug --- githubcommit/handlers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/githubcommit/handlers.py b/githubcommit/handlers.py index e88f285..2867cf6 100644 --- a/githubcommit/handlers.py +++ b/githubcommit/handlers.py @@ -61,7 +61,7 @@ def put(self): subprocess.run(['jupyter', 'nbconvert', '--to', 'script', str(os.environ.get('GIT_PARENT_DIR') + "/" + os.environ.get('GIT_REPO_NAME') + filename)]) filename = str(os.environ.get('GIT_PARENT_DIR') + "/" + os.environ.get('GIT_REPO_NAME') + filename.replace('ipynb', 'py')) - print(repo.git.add(str(os.environ.get('GIT_PARENT_DIR') + "/" + os.environ.get('GIT_REPO_NAME') + filename))) + print(repo.git.add(filename)) print(repo.git.commit( a=False, m="{}\n\nUpdated {}".format(msg, filename) )) except GitCommandError as e: From f0091e6b06ff753ba40f14fa97c8ba17d2326466 Mon Sep 17 00:00:00 2001 From: Shaleen Date: Tue, 22 Sep 2020 23:15:03 +0530 Subject: [PATCH 2/4] Corrected filename when commit to source not selected. --- githubcommit/handlers.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/githubcommit/handlers.py b/githubcommit/handlers.py index 2867cf6..13228df 100644 --- a/githubcommit/handlers.py +++ b/githubcommit/handlers.py @@ -60,7 +60,9 @@ def put(self): if commit_only_source : subprocess.run(['jupyter', 'nbconvert', '--to', 'script', str(os.environ.get('GIT_PARENT_DIR') + "/" + os.environ.get('GIT_REPO_NAME') + filename)]) filename = str(os.environ.get('GIT_PARENT_DIR') + "/" + os.environ.get('GIT_REPO_NAME') + filename.replace('ipynb', 'py')) - + else: + filename = str(os.environ.get('GIT_PARENT_DIR') + "/" + os.environ.get('GIT_REPO_NAME') + filename) + print(repo.git.add(filename)) print(repo.git.commit( a=False, m="{}\n\nUpdated {}".format(msg, filename) )) From 7c80d94f5f1f5d9ec4ec2634031d4d7e65896a0f Mon Sep 17 00:00:00 2001 From: Shaleen Date: Wed, 23 Sep 2020 20:23:18 +0530 Subject: [PATCH 3/4] Added the installation video link in readme --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 15b25bc..06bed06 100644 --- a/README.md +++ b/README.md @@ -24,6 +24,9 @@ jupyter nbextension enable githubcommit --user --py ``` ## Steps +I have made this short video in which I install the extension from scratch (click on the image)- + +[![Watch the video](https://i.ibb.co/7bk1bJ2/Webp-net-resizeimage.png)](https://youtu.be/vKx_4zFvOi8) * Install package using above commands * Create Git repo where notebooks will be pushed if not already exists and clone it in your `GIT_PARENT_DIR` From 12d1dcba808d68148a6232bbbe202d4a327d3ce1 Mon Sep 17 00:00:00 2001 From: Shaleen Anand Taneja Date: Sat, 24 Jul 2021 18:12:55 +0530 Subject: [PATCH 4/4] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 06bed06..b1095a3 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,7 @@ jupyter nbextension enable githubcommit --user --py ## Steps I have made this short video in which I install the extension from scratch (click on the image)- -[![Watch the video](https://i.ibb.co/7bk1bJ2/Webp-net-resizeimage.png)](https://youtu.be/vKx_4zFvOi8) +[![Watch the video](https://i.ibb.co/7bk1bJ2/Webp-net-resizeimage.png)](https://www.youtube.com/watch?v=1XPSK1mxfgQ) * Install package using above commands * Create Git repo where notebooks will be pushed if not already exists and clone it in your `GIT_PARENT_DIR`