Repository navigation
fix(avatars): Add type to Fetch avatar - #3560
Merged
Merged
Conversation
Contributor
|
Can you please add a description for the PR? |
bfoxx1906
reviewed
May 28, 2024
greg-in-a-box
requested changes
May 28, 2024
greg-in-a-box
left a comment
Contributor
There was a problem hiding this comment.
Can we add some more unit tests, the snapshot that was updated is only covering the test coverage from feature level but not at the component level where they could be used in other places outside of USM
Contributor
Author
|
@greg-in-a-box added some tests. Can you take a look. |
greg-in-a-box
approved these changes
May 30, 2024
JChan106
approved these changes
May 30, 2024
kajarosz
pushed a commit
to kajarosz/box-ui-elements
that referenced
this pull request
Aug 21, 2024
* fix(avatars): Add type for fetchAvatarUrl calls in USM * fix(avatars): Add type for fetchAvatarUrl calls in USM * fix(avatars): Add type for fetchAvatarUrl calls in USM * fix(avatars): Add type for fetchAvatarUrl calls in USM * fix(avatars): Add type for fetchAvatarUrl calls in USM * fix(avatars): Add type for fetchAvatarUrl calls in USM --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description :
The Unified Shared modal component receive callback functions to fetch Avatar URLs.
This fix add contact
typeto the callback function. The contact type is already available in in the Contact object ( 'user' or 'group') and is returned as part of API response.The 'type' param and prop is set as optional, and can be null or undefined if it's not present in the contact object.