Repository navigation
feat(threaded-replies): Refactor Comment component to functional - #3270
Merged
Merged
Conversation
karelee7
reviewed
Mar 2, 2023
karelee7
reviewed
Mar 2, 2023
tjuanitas
reviewed
Mar 7, 2023
tjuanitas
reviewed
Mar 7, 2023
karelee7
reviewed
Mar 8, 2023
patlm
reviewed
Mar 8, 2023
tjuanitas
reviewed
Mar 8, 2023
JChan106
requested review from
patlm and
tjuanitas
and removed request for
patlm
March 9, 2023 00:46
tjuanitas
previously approved these changes
Mar 9, 2023
tjuanitas
left a comment
Contributor
There was a problem hiding this comment.
looks fine to me. do we have tickets created to do the clean up (rename file and remove props) after the release?
Contributor
Author
Good point, just created a ticket for the cleanup with those actions as acceptance criteria. Thanks for the review! |
bfoxx1906
reviewed
Mar 9, 2023
bfoxx1906
reviewed
Mar 9, 2023
Refactors Comment component for easier readability/development
bfoxx1906
approved these changes
Mar 9, 2023
tjuanitas
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to refactor the Comment component from a class based component, to a functional component. This will make it easier to develop/read for the heavy Threaded Replies refactor we are starting. We created a separate component called "BaseComment" which will be used behind our ThreadedReplies FF. Once we are finished with Threaded Replies, we can have this replace the current Comment component.
Test comment:
Test reply:
Test modify:
Test delete:
