Repository navigation
fix(content-explorer): enable create folder with trailing space in name - #3246
Conversation
| this.api.getFolderAPI().create( | ||
| id, | ||
| name, | ||
| name.trim(), |
There was a problem hiding this comment.
Adding trim() function to remove the trailing whitespace when create button has been clicked.
There was a problem hiding this comment.
I noticed there's an existing bug on line 1197, could we add a trim() there as well? it doesn't look like that if would ever enter because of the if right before it.
this way it'll be a little similar to rename functionality:
|
Note: edited the description to remove jira link |
QingyuChai
left a comment
There was a problem hiding this comment.
lgtm! Just wondering, is there any way to add this to the tests somewhere? Just a check to make sure we are trimming the name?
Yeah, maybe we could add test for both rename and create folder flow at content-explorer tests. |
No description provided.